Deprecation/remove basic transformation tables #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
#93
This PR will result in the following new package version:
1.3.0 as this is very breaking for the 2 customers still using basic SQL transformations (and anyone looking at the stale tables for historical analyses)
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR removes the
transformation
andtrigger_table
sources, staging models, variables, documentation, and downstream transforms (essentially the entirefivetran_platform__transformation_status
end model)It does NOT remove
transformation_id
and transformation-oriented logic from the staing log model. I chose not to remove this for 2 reasons:LOG
. We should continue to correctly label thesetransformation
andtrigger_table
tables next year, solog.transformation_id
could become relevant again (and isn't causing trouble)PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
See the Hex notebook (in height ticket) for my sanity check validations, but truthfully the validation for this task is largely non-sql. Transformations and triggers were only involved in the now-deprecated
transformation_status
end model. No other end models depend on these sources.So outside of SQL and into the CLI...
On main, if you do not have

fivetran_platform_using_transformations
andfivetran_platform_using_triggers
set toFalse
and you don't have the transformation and trigger_table, adbt run
would result inOne must set these variables to False explicitly (they are true by default) for a successful run

Thus, this PR makes so it that we achieve the above image without having users (who almost certainly don't have these tables and/or don't want to transform stale data) set any variables.
So if i comment these back out

And dbt run, everything works out

Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🥶