Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/file-adjustments #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

What change does this PR introduce?

This PR adds the LICENSE file to the master branch while also removing the unnecessary .DS_Store file.

If this PR introduces a new macro, how did you test the new macro?

N/A

If this PR introduces a modification to an existing macro, which packages is the macro currently present in and what steps were taken to test compatibility across packages?

N/A

Did you update the README to reflect the macro addition/modifications?

  • Yes
  • No (provide further explanation)

No README changes required. This only modifies the LICENSE, .DS_Store, and .gitignore files in the master branch for consistency with the latest release contents. Please be aware that the master branch is not used in the latest release. This branch is preserved for backwards compatibility with a previous implementation of Fivetran Utils.

Copy link

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but had a question, I noticed there's a .gitignore file in the integration tests folder for this package, but not others-- is it necessary for this package?

Ah never mind, because it's fivetran utils haha

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review August 12, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants