Feature/advertiser addition #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ), joined as ( | ||
|
|
||
| select | ||
| report.date_day as campaign_date, | ||
| advertiser.advertiser_id, |
There was a problem hiding this comment.
A couple of q's:
- Is advertiser_id meant to be similar to account_id in other ad sources?
- If yes, do you think it'd be beneficial to add advertiser_id & advertiser_name to the other two intermediate tables (ad_group_ad_report & campaign_ad_report)? I notice that we are currently doing that for a couple of other packages e.g. facebook_ads, snapchat.
There was a problem hiding this comment.
That's a great point. I think it would be beneficial to bring the advertiser information into these other models. I just added these fields to the other models.
fivetran-sheringuyen
approved these changes
Jan 4, 2022
|
@fivetran-sheringuyen your above comment got me thinking some more... Before merging this I want to 100% confirm that Advertisers share the same functionality as Accounts in the other ad platforms. With the data we have tested this seems to be the case. However, I want to confirm this is before we move forward with this PR. |
|
This will be integrated into PR #21 |
Merged
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
This PR adds the
advertiser_historymodel into thead_adapterfinal. This allows for the advertiser name to be carried through. Thisadvertiser_namewill then be used to provide theaccount_nameto the final roll up report in thead_reportingpackage.Does this PR introduce a breaking change?
This should not be a breaking change. 96% of Fivetran Pinterest customers have the
advertiser_historymodel. As such, it would be safe to keep this as a patch upgrade.Is this PR in response to a previously created Issue
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🩹
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.