Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner SDK: Destination examples for V2 protos #81

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fivetran-satvikpatil
Copy link
Contributor

@fivetran-satvikpatil fivetran-satvikpatil commented Jan 7, 2025

Link T-849691

Description

Added V2 examples for destination

Testing

  • Java
Screenshot 2025-01-07 at 10 10 26 PM Screenshot 2025-01-07 at 10 10 40 PM
  • Python
Screenshot 2025-01-07 at 10 05 34 PM Screenshot 2025-01-07 at 10 05 47 PM

Copy link

height bot commented Jan 7, 2025

This pull request has been linked to 1 task:

💡Tip: Add "Close T-849691" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@fivetran-satvikpatil fivetran-satvikpatil marked this pull request as ready for review January 7, 2025 16:46
@fivetran-satvikpatil fivetran-satvikpatil force-pushed the satvik/v2-destination-examples branch from c04a08c to 85f7ff8 Compare January 9, 2025 04:49
Comment on lines +149 to +159
conditional_field_for_file = common_v2_pb2.FormField(
name="doesNotMatterFile",
label="It won't be used",
conditional_fields=conditional_fields_for_file
)

conditional_field_for_database = common_v2_pb2.FormField(
name="doesNotMatterDatabase",
label="It won't be used",
conditional_fields=conditional_fields_for_database
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use better placeholders for the name and label fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants