Generic ZipMatch instances #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fizruk
force-pushed
the
generic-zip-match
branch
from
8c54fd7 to
97d7218
Compare
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
ZipMatchin free foil is defined forBifunctors, regularGenericorGeneric1is not enough. Luckily,kind-genericsprovide a super-general version calledGenericK, which encompasses all other generics, and in particular it coversGeneric2, which we'd be interested in.However, instead of giving a generic implementation for
ZipMatch2, we implement a more general case forZipMatchwith arbitrarily many type parameters!Note that
ZipWithKalso works for nullary type constructors, which allows specifying whether to compare ground types or not. E.g. we setZipWithK BNFC'Positionto always successfully match, making sure that location does not affect matching of terms.