Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

185 - Improves page layout with additional fx blocks #32

Merged
merged 2 commits into from
Oct 9, 2024
Merged

185 - Improves page layout with additional fx blocks #32

merged 2 commits into from
Oct 9, 2024

Conversation

A-Souhei
Copy link
Contributor

@A-Souhei A-Souhei commented Oct 9, 2024 •
edited
Loading

Description

I have added two more blocks for footer background effects and radial effects (to enable or disable them).

Relates fjelltopp/ckanext-zarr#45

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@A-Souhei A-Souhei mentioned this pull request Oct 9, 2024
Merged
12 tasks
@A-Souhei A-Souhei self-assigned this Oct 9, 2024
@A-Souhei A-Souhei added enhancement New feature or request minor labels Oct 9, 2024
ChasNelson1990
ChasNelson1990 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChasNelson1990 ChasNelson1990 merged commit 1a44238 into main Oct 9, 2024
0 of 2 checks passed
@ChasNelson1990 ChasNelson1990 deleted the 185-fjelltopp-theme-leaks-through-on-the-footer branch October 9, 2024 07:58
@ChasNelson1990
Copy link
Member

Merged on your behalf as about to do a staging deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChasNelson1990 ChasNelson1990 ChasNelson1990 approved these changes

Assignees

@A-Souhei A-Souhei

Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A-Souhei @ChasNelson1990