Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title (delete after following this rule)
Your PR title should be prefixed with a Conventional Commit tag (https://www.conventionalcommits.org/en/v1.0.0/; e.g.
feat:
orfix:
).Description
Please include a summary of the change(s) and a sentence summary of the motivation.
You should also include screenshots or videos of UI changes.
Don't forget to reference all issues and other pull requests which are associated to this one below, especially if merging need to be coordinated.
E.g.
closes #issue_numner
relates fjelltopp/repository_name#pull_request_number
Dependency Changes (delete if not applicable)
List any dependencies that have been removed/added/changed in this pull request and explain why.
Has the pipfile.lock or yarn.lock been updated?
If dependency management for this project is centralised, e.g.
adx_deploy
for ADR, please link to the coordinated PR in the project repo.Testing (delete if not applicable)
Please describe the rationale behind any new tests that have been added for this change, e.g.
Documentation (delete if not applicable)
Please describe any new technical documentation that has been added to Confluence for this change.
Environment Changes (delete if not applicable)
Have any environment variable changes been committed as part of this pull request?
Is there a matching PR in fjelltopp/fjelltop-infrastructure for these changes?
Have any README or Confluence install instructions been updated to reflect this change?
Internationalisation and Localisation (delete if not applicable)
Do any UI changes require internationalisation (i18n) or localisation (l10n) changes.
If new translations are required, have you created new Jira tickets for each language and informed the appropriate project manager?
Checklist
Put an
x
in the boxes that apply to this pull request (you can also fill these out after opening the pull request).You may not need to check all boxes.