Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

"Add Dataset" is not used in dashboard_datasets #35

Closed
wants to merge 1 commit into from

Conversation

A-Souhei
Copy link
Contributor

@A-Souhei A-Souhei commented Sep 25, 2024

Description

image

We use "Create new dataset" on the "My account" page but "Add Dataset" on the "Find Data" page, let's use "Add Dataset" for both.

Closes fjelltopp/zarr-ckan#171

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@A-Souhei A-Souhei added the bug Something isn't working label Sep 25, 2024
@A-Souhei A-Souhei self-assigned this Sep 25, 2024
@A-Souhei A-Souhei added the minor label Sep 25, 2024
@A-Souhei A-Souhei marked this pull request as ready for review September 25, 2024 11:24
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, is this another one that maybe belongs in fjelltopp-theme?

@A-Souhei A-Souhei closed this Sep 26, 2024
@A-Souhei A-Souhei deleted the 171-create-new-dataset-vs-add-dataset branch September 26, 2024 07:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Create new dataset" vs "Add Dataset"
2 participants