Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge ckanext-zarr as a subtree #160

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

ChasNelson1990
Copy link
Member

@ChasNelson1990 ChasNelson1990 commented Sep 1, 2024

Description

In order to reduce the number of commits, PRs and everything else - I have merged the git tree for ckanext-zarr into this repository.

The structure of the folder and all files remains the same.

I have moved the .github folder from the extension into the root of this project and updated it so that the Pipfile is used and tests are run on PRs in this repo.
edit: I have been unable to get the GitHub Action tests working due to seeming incompatibilities with the ckan base image and pipenv.

Dependency Changes

Removes the submodule dependency.

Checklist

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

ChasNelson1990 and others added 18 commits July 16, 2024 08:43
…#3)

* _

* Adding helper functions / extended fjelltopp-theme layout

* Adding helper functions / extended fjelltopp-theme layout

* Adding helper functions / extended fjelltopp-theme layout

* _

* scaled promoted bg image

* _

* _

* Updated 'recently updated'

* Moved package item template to fjelltopp theme

* Removed a few helpers to clean code

* Added the topics section

* Updated :
fjelltopp-theme
added disclaimer
about

* Updated :
Insights

---------

Co-authored-by: toavina <[email protected]>
…eme without further changes (#5)

Co-authored-by: toavina <[email protected]>
* Updates copyright value

* Updates subscribe_to_updates.html subtext content

* Dataset search fa-search hover fixed

* Dataset search fa-search hover fixed

* Removed the extended subcribe_to_updates.html

* fix .fa-search color

---------

Co-authored-by: toavina <[email protected]>
* Added a draft schema for Dublin Core and a dcat profile to include the elements in dcat export

* Small change to doi label

* Small changes for a few help_text

* Updates to schema

* Updates to schema

* Updates to schema

* Convert Json Schema to Yaml

* Updates to UI

* Updates to UI

* Updates to schema

* Added validator for date, a few fix for UI

* Fixing multiple select

* Macro for multiple select

* Using yaml schema now

* css fix

* Small code fix

* Default metadata for resources

* Small fix for multiple_select_formatter

* wip: add file uploader (#9)

* Code improvements for additional_info.html and helpers.py

* Remove excess of lines from zarr.css

* Moved the namespace with others

* Updated the language field as a single select

* Updated the language field as a single select

* Renamed schema

* Commented profiles.py as WIP

---------

Co-authored-by: toavina <[email protected]>
Co-authored-by: Chas Nelson <[email protected]>
* About content updated with styling

* About content updated with styling

---------

Co-authored-by: toavina <[email protected]>
* feat: add a placeholder video to the homepage

* fix: make iframe responsive

* fix: make caption i18n friendly
* Removed insight section

* Removed max-width for bottom search footer button

* Updating search button

* Updating search button

* small comment

* a bit of customization for datahub stats

* fix: keep insights

---------

Co-authored-by: toavina <[email protected]>
Co-authored-by: Chas Nelson <[email protected]>
…ge (#22)

* using groups with extra whose key is 'topic' and value is 'yes'

* Removed filtering

* Removed filtering

* Updated the name 'topic' to 'Resource Type'

---------

Co-authored-by: toavina <[email protected]>
* Removed extra 'Learn more about the repository'

* Still under development banner color white / green background

* update grays in datasets and resource read

* changes inactive stage background color

* needs rebase

---------

Co-authored-by: toavina <[email protected]>
Co-authored-by: Chas Nelson <[email protected]>
* feat: simplify schema

* fix: minor improvement to subject placeholder
@ChasNelson1990 ChasNelson1990 added the enhancement New feature or request label Sep 1, 2024
@ChasNelson1990 ChasNelson1990 self-assigned this Sep 1, 2024
@ChasNelson1990
Copy link
Member Author

I would be up for discussing this and what I was trying to do on Monday if people are free?

@ChasNelson1990
Copy link
Member Author

Marking as not draft so Jenkins will build it

@ChasNelson1990 ChasNelson1990 marked this pull request as ready for review September 1, 2024 11:24
@ChasNelson1990 ChasNelson1990 marked this pull request as draft September 1, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants