Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isLoading prop to the IconProps #1003

Closed
kaciakmaciak opened this issue Sep 26, 2023 · 0 comments
Closed

Add isLoading prop to the IconProps #1003

kaciakmaciak opened this issue Sep 26, 2023 · 0 comments
Labels

Comments

@kaciakmaciak
Copy link

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

The icon prop props argument` is an object with the following signature:

export interface IconProps {
  theme: Theme;
  type: TypeOptions;
}

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below:

What is the expected behavior?

Could we please add isLoading to the IconProps so that we can display the spinner in that case? Currently, the spinner is hidden in case custom icon prop is provided.

export interface IconProps {
  theme: Theme;
  type: TypeOptions;
  isLoading: boolean;
}

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

N/A

I'm happy to contribute to resolve this.

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants