Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zindex in safari #339

Merged
merged 1 commit into from
May 22, 2019
Merged

Fix zindex in safari #339

merged 1 commit into from
May 22, 2019

Conversation

micalgenus
Copy link
Contributor

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test).
  5. Run yarn start to test your changes in the playground.
  6. Update the readme is needed
  7. Update the typescript definition is needed
  8. Format your code with prettier (yarn prettier-all).
  9. Make sure your code lints (yarn lint:fix).

Learn more about contributing here

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.99% when pulling 6732eb7 on micalgenus:master into 1991ed2 on fkhadra:master.

Copy link
Owner

@fkhadra fkhadra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @micalgenus,

Sorry for the late reply. Could you share with me a codesandbox that reproduce the issue please.

Thank you

@micalgenus
Copy link
Contributor Author

Copy link
Owner

@fkhadra fkhadra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micalgenus thank you for sharing !

@fkhadra fkhadra merged commit 6732eb7 into fkhadra:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants