Make sure the CNI delete function does not fail when the json config is wrong #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
reviewed
Nov 10, 2022
| @@ -135,7 +135,8 @@ func doCmdDel(args *skel.CmdArgs, n *NetConf) (err error) { | |||
|
|
|||
| nc := &types.NetConf{} | |||
| if err = json.Unmarshal(netConfBytes, nc); err != nil { | |||
| return fmt.Errorf("failed to parse netconf: %v", err) | |||
| fmt.Fprintf(os.Stderr, "failed to parse netconf: %v", err) | |||
| return nil | |||
There was a problem hiding this comment.
the consequence is that we are leaving "zombie" interfaces in the bridge, right?
There was a problem hiding this comment.
Yes, exactly. At least until the node is rebooted.
|
This is related to flannel-io/flannel#1662 |
…is wrong Otherwise, the kubelet gets stuck deleting a pod
thomasferrandiz
force-pushed
the
main
branch
from
2c24cbe to
acb770d
Compare
rbrtbnfgl
approved these changes
Nov 28, 2022
manuelbuil
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the kubelet gets stuck deleting a pod