pkg/ip/iface_windows_test.go: fix TestGetInterfaceByIP #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetInterfaceIP4Addrs returns slice of IP Addresses. Add loop around to test all addresses to fix a type mismatch
manuelbuil
approved these changes
Nov 24, 2022
rbrtbnfgl
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix type mismatch in windows test TestGetInterfaceByIP
Description
GetInterfaceIP4Addrs, used in windows test function TestGetInterfaceByIP (file iface_windows_test.go), returns a slice of IPAddresses. The test is done only for single IP address instead of the returned slice. This leads to a type-mismatch error. To fix this a loop was introduced to check all IP Addresses of the interface.