Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move leases away from package subnet #1698

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

manuelbuil
Copy link
Collaborator

Signed-off-by: Manuel Buil [email protected]

Description

Trying to declutter the subnet package which is big and contains lots of different stuff. In this case, I am trying to move everything around leases into its own package. Summary::

  • Create "package lease" which includes the structs: Event, LeaseAttrs, Lease, LeaseWatchResult and LeaseWatcher
  • Remove "(l *Lease) Key()" function which was only used in etcd tests. Create it there
  • Remove "MarshalJSON()" and "UnmarshalJSON()" functions from EventType because they were never used
  • Remove file pkg/subnet/watch.go and move its content into "package lease" or "package subnet" depending on where it makes sense

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@manuelbuil manuelbuil force-pushed the leases branch 2 times, most recently from 5826e01 to a6a26e4 Compare December 28, 2022 15:01
@manuelbuil manuelbuil merged commit 1cdb049 into flannel-io:master May 17, 2023
@manuelbuil manuelbuil deleted the leases branch May 17, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants