flanneld: add etcd authentication #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jipperinbham
force-pushed
the
etcd-basic-auth
branch
4 times, most recently
from
e56d58c to
be5d344
Compare
|
@jipperinbham Your patch seems to do some whitespace cleanup and add a feature. I think you should split that into two separate patches. |
|
@glevand sorry about the whitespace cleanup, editor must have done something there, I'll get it cleaned up. |
jipperinbham
force-pushed
the
etcd-basic-auth
branch
from
9f69470 to
0915f48
Compare
expose username and password as options for configuration to etcd Fixes flannel-io#419
jipperinbham
force-pushed
the
etcd-basic-auth
branch
from
0915f48 to
459a59c
Compare
|
Dupe of #409, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose username and password as options for configuration to etcd
Fixes #419