Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Exclude CL withdrawals from profit calculation #144

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

dvush
Copy link
Contributor

@dvush dvush commented Feb 19, 2024

📝 Summary

This adds a new flag --builder.validation_exclude_withdrawals that changes how validation API calculates profit of the bid.

If enabled block validation API will exclude CL withdrawals to the fee recipient from the balance delta that is used to calculate profit of the fee recipient.


Copy link
Contributor

@avalonche avalonche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should use the WITHDRAWALS_SCORING_ACTIVATION_EPOCH as a flag instead to determine when to exclude withdrawals

@dvush
Copy link
Contributor Author

dvush commented Mar 7, 2024

  • relays decided to enable it when they want not on the epoch but approximately before dencun
  • linter is horribly broken and needs closer investigation anyway

@dvush dvush merged commit 4ff4c10 into main Mar 7, 2024
2 of 3 checks passed
@dvush dvush deleted the exclude-withdrawals branch March 7, 2024 14:54
austonst pushed a commit to aestus-relay/builder that referenced this pull request Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants