Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay sys-kernel/coreos-sources: backport patch #1144

Closed
wants to merge 1 commit into from

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Sep 15, 2023

@tormath1 tormath1 requested a review from a team September 15, 2023 07:24
@tormath1 tormath1 self-assigned this Sep 15, 2023
Comment on lines 80 to 81
struct mlx5_irq_pool *pool = irq->pool;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these lines as well, otherwise there is an "unused variable" warning during the build

@@ -0,0 +1,113 @@
From 0a5b94bd2b4775092acdbb077dcb2ea45dbf777e Mon Sep 17 00:00:00 2001
From: Mathieu Tortuyaux <[email protected]>
Copy link
Member

@jepio jepio Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically you want to preserve ownership so this line would be

From: Saeed Mahameed <[email protected]>

when you send it to the mailing list, the email will be from you but this will show up as the first line.

Like here: https://lore.kernel.org/stable/[email protected]/T/#u (first example i found).

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

@tormath1
Copy link
Contributor Author

Patches have been sent to the upstream (https://lore.kernel.org/stable/[email protected]/ and https://lore.kernel.org/stable/[email protected]/) - closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants