-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ue-rs to image #1148
Add ue-rs to image #1148
Conversation
@@ -0,0 +1 @@ | |||
ue-rs-9999.ebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if having ue-rs-9999
makes any sense. Could we have ue-rs-0.1.0-r1.ebuild
as a regular file and drop the 9999
one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could, but the original idea behind the 9999 ebuild is that it makes the history easier to follow (you can blame git log
/git blame
). if you think this doesn't make sense any more i'll remove the symlink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would keep this as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git blame
should be smart enough to follow renames. But I'm not going to block the PR on this.
sdk_container/src/third_party/coreos-overlay/coreos-base/ue-rs/ue-rs-9999.ebuild
Outdated
Show resolved
Hide resolved
Based on the afterburn ebuild with some tweaks. The dependency list was generated using cargo-ebuild. Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ebuild looks sensible and tests run fine. LGTM.
Add ue-rs to image
<to be filled by @wrl>
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.