Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #6

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Update #6

merged 2 commits into from
Aug 13, 2022

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Aug 12, 2022

No description provided.

@flathubbot
Copy link

Started test build 104695

@flathubbot
Copy link

Build 104695 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102384/com.github.artemanufrij.playmyvideos.flatpakref

@gasinvein
Copy link
Member

Did you test this, does it work as expected?

@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 13, 2022

Did you test this, does it work as expected?

Yes seems to work. Except grabbing media keys probably never worked:

** (com.github.artemanufrij.playmyvideos:2): WARNING **: 06:24:06.216: MediaKeys.vala:56: Could not grab media player keys: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown

I think this https://github.com/artemanufrij/playmyvideos/blob/5aef166b21856d7847e740ff98b4bbfb0e20a51f/src/Interfaces/MediaKeys.vala#L45 should be:

- media_keys = Bus.get_proxy_sync (BusType.SESSION, "org.gnome.SettingsDaemon", "/org/gnome/SettingsDaemon/MediaKeys");
+ media_keys = Bus.get_proxy_sync (BusType.SESSION, "org.gnome.SettingsDaemon.MediaKeys", "/org/gnome/SettingsDaemon/MediaKeys");

@gasinvein gasinvein merged commit 4585d8c into flathub:master Aug 13, 2022
@gasinvein
Copy link
Member

Thanks.

@bbhtt bbhtt deleted the update branch August 13, 2022 13:25
@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 13, 2022

Do you want a patch for the above issue? I've opened artemanufrij/playmyvideos#49

@gasinvein
Copy link
Member

The app seems abandoned, no code updates since 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants