Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host-spawn #375

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Add host-spawn #375

merged 2 commits into from
Aug 22, 2023

Conversation

ran-dall
Copy link
Contributor

Closes #315 #197 #62

This commits add host-spawn to this Flatpak in /app/bin.

Also, updates the README.md with the options to use host-spawn.

@flathubbot
Copy link
Contributor

Started test build 20170

@flathubbot
Copy link
Contributor

Build 20170 failed

@flathubbot
Copy link
Contributor

Started test build 20179

@flathubbot
Copy link
Contributor

Build 20179 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/2812/com.visualstudio.code.flatpakref

@flathubbot
Copy link
Contributor

Started test build 28637

@flathubbot
Copy link
Contributor

Build 28637 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/11304/com.visualstudio.code.flatpakref

@flathubbot
Copy link
Contributor

Started test build 29012

@flathubbot
Copy link
Contributor

Build 29012 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/11676/com.visualstudio.code.flatpakref

@lbssousa
Copy link
Contributor

While this PR is not merged, one can install host-spawn binary to directory $HOME/.var/app/com.visualstudio.code/data/node_modules/bin (it’s already in VSCode Flatpak’s PATH)

@lbssousa
Copy link
Contributor

Wouldn't it be better to package this as an add-on for VSCode Flatpak (e.g. com.visualstudio.code.tool.host-spawn)?

Could it be possible to ship separate add-ons for providing host-spawn symlinks to notorious binaries (e.g. com.visualstudio.code.tool.host-spawn.podman, com.visualstudio.code.tool.host-spawn.fish, com.visualstudio.code.tool.host-spawn.bash, etc.)?

@mdmundo
Copy link

mdmundo commented Jun 20, 2023

i made a pr.

@alatiera
Copy link
Member

alatiera commented Aug 22, 2023

This looks good and works better than the current flatpak-spawn snippet. Not entirely excited to depend on something else than flatpak-spawn but host-spawn seems okayish in general.

cc @bilelmoussaoui This would be good to merge given #315

@flathubbot
Copy link
Contributor

Started test build 60279

This commits add `host-spawn` to this Flatpak in `/app/bin`.
@flathubbot
Copy link
Contributor

Build 60279 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42913/com.visualstudio.code.flatpakref

@flathubbot
Copy link
Contributor

Started test build 60284

@flathubbot
Copy link
Contributor

Build 60284 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42918/com.visualstudio.code.flatpakref

@bilelmoussaoui bilelmoussaoui merged commit db41a6c into flathub:master Aug 22, 2023
@ran-dall
Copy link
Contributor Author

Big thank you to @alatiera, @bilelmoussaoui, and everyone else that participated in getting this merged!

@lbssousa
Copy link
Contributor

Please update host-spawn to version 1.4.2. It's needed to spawn host-system podman properly.

@alatiera
Copy link
Member

Please update host-spawn to version 1.4.2. It's needed to spawn host-system podman properly.

Wanna file a PR? Bumping the version and changing the sha should be everything needed hopefully :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants