Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider filesystem=home permision #38

Open
Tiagoquix opened this issue Jan 24, 2025 · 3 comments
Open

Reconsider filesystem=home permision #38

Tiagoquix opened this issue Jan 24, 2025 · 3 comments

Comments

@Tiagoquix
Copy link

I think using filesystem=home by default is too broad. We should probably prefer the Flatpak portal where it gives access to specific files (and also prefer user overrides for specific folders, of course).

@kjarosh
Copy link
Collaborator

kjarosh commented Jan 24, 2025

Ruffle does support XDG portals, however as of now it's problematic to disable that permission, as movies can load other files next to them. We need to add proper UI and support for loading multi-file movies.

Currently, we use filesystem=home permission, although Ruffle will ask if a movie wants to access a file outside of the directory where the movie is located.

@Tiagoquix
Copy link
Author

An user can have movie files in /media/MyDrive/Ruffle_files, for example. He would need to add an override and filesystem=home wouldn't suffice by default.

One thing we can do is use a specific folder for Ruffle files and tell users to use it the first time the app is opened. Such as:

This Flatpak version of Ruffle is sandboxed and only reads files from `$HOME/Videos/Ruffle Movies` by default.
You can add a Flatpak override to allow Ruffle to access other locations, and you can also change the setting for the default folder in the options.

With that, a new setting would also be created, called "Default folder", and it would be basically the folder that opens by default when Ruffle accesses the file picker (it would also create the folder if it does not exist when opening the app).


The ideal solution, of course, would be that when a file is selected Ruffle gains access to all the files in that file's folder, so it would deal with the problem of movies loading other files next to them. This way, it uses "Flatpak documents" and files are stored temporarily in /run/user/1000/doc or something similar.

@torokati44
Copy link

See: flatpak/xdg-desktop-portal#463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants