-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop app] Add ability to load SWF-specific settings from configuration file #19325
Comments
I believe this feature request is fully covered by our Ruffle Bundle mechanism. You can create a Ruffle Bundle, which includes all required files for a movie to run, along with its configuration. See https://github.com/ruffle-rs/ruffle/tree/master/frontend-utils/src/bundle for details. Currently there's no user interface to create such bundles, they need to be crafted by hand. |
I didn't even know that existed. Thanks for the info! I think the only downside of the Ruffle Bundle is that it doesn't seem to allow for multiple files in a same directory, because all config. files would be named As I see it, it is also not possible to use one Ruffle Bundle file for multiple items, since it's not (apparently) possible to use something like (in a single file): [bundle.mygame1]
(properties here)
[player.mygame1]
(properties here)
[bundle.mygame2]
(properties here)
[player.mygame2]
(properties here) |
The idea is that you put every game into its own bundle. |
Yes, I understand that. But I think my original feature request is also a good idea to implement. The only thing needed to implement my original suggestion would be to detect This way, it still makes it possible to implement my idea without having to deviate too much from the current implementation. |
@Tiagoquix the idea of Ruffle Bundle is to bundle a movie into one archive file which contains everything. The resulting file (e.g. named |
With that new information I believe that my original idea would need more changes to be implemented then, since I'm asking for an auto-detected config. file, which is not possible without a Therefore, I think my suggestion can remain opened since my original intention is to have multiple files (one SWF, one TOML) next to each other instead of having to create a bundle. However, if you guys think this is unnecessary and that the bundle already suffices (and that by doing my suggestion it would create more complications), then feel free to close the issue. Thanks! |
Your idea sounds convenient for users, I like it 👍 |
The approach of looking for various files all over the disk is problematic wrt filesystem isolation. The current state of "movies loading other files" produces enough issues, but people at least are aware of single-file vs multi-file movies. It wouldn't be a problem (maybe despite being non-intuitive) on Windows which does not have any filesystem sandboxing, but it would be on MacOS and Linux. On top of that, a movie wouldn't consist of a single file, so sharing the movie would always require making an archive on the TX side, sharing it, extracting the archive on the RX side, running the movie, which requires more steps and more things can go wrong. Not to mention that you would have to keep those two files in the same directory at all times, etc. Personally, I'm against this feature as I think Ruffle bundles are superior to that approach, and it will cause more issues than help in the long run. Edit: In my opinion, it would be better to implement creating bundles in a simple way (e.g. from a running movie, preserving all settings). |
See also for instance flathub/rs.ruffle.Ruffle#38. People in general want filesystem isolation fully enabled, and I think it's a good idea, as it improves safety a lot. |
I agree. In the long term, a simpler way to create Ruffle Bundles would be better than adding my idea which could cause more confusions. Not that Ruffle Bundles are hard to create; I could create one by reading the documentation, because it seems reasonable, but making it simpler (preferably with an UI) would certainly be good. With that in mind, would it be OK to change my feature request to something such as "Add an UI to create Ruffle Bundles"? If yes, should I re-use this issue or should I create a new one? Thanks! |
There's been a bit of discussion going on here, so I'd preserve that and create a new issue with a proper description which links to this one :) |
When you watch a video using the VLC media player, subtitles are automatically embedded if the subtitles file uses the same name as the original video file (and ends with
.srt
extension).A similar thing could be done for Ruffle, either using TXT or TOML files.
For example, there's a game I like to play called Age of War 2, one of the classic Flash games.
To unlock the Insane (maximum) difficulty in-game, I have to use the follwing property:
Spoof SWF URL: http://farm.maxgames.com/ageofwarupdate1MzYx.swf
This could be automated by using the following logic:
SWF file is
age-of-war-2-publicOTM3.swf
.SWF-specific settings are stored in
age-of-war-2-publicOTM3.txt
.Settings follow the following format:
When loading the SWF file, if a TXT or TOML file is also found in the same folder with the same name as the SWF file, automatically load the settings from the file or prompt the user to allow loading.
The text was updated successfully, but these errors were encountered: