-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storefront-info-endpoint configuration #65
Conversation
c28bf6d
to
18d3137
Compare
96f0509
to
70b5a1a
Compare
This adds a dependency on libostree >=2021.5 for rewriting commits. This caused some issues with CI, so I had to change the jobs to use Ubuntu 22.04 rather than |
0bbd049
to
b025e71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of places where you added an Eq
derive - was this needed for the ostree stuff? In this instance it won't add a huge amount to compile times / binary size; but in general it's not a great idea to blanket-add derives unless you need them. Obvs. if you need them then so-be-it, which is why I didn't highlight them in the main review comments.
Generally this looks good; though I pretend no ability to judge the ostree work.
b025e71
to
4840392
Compare
As for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone with minimal experience of ostree etc. the Rust itself looks nice now.
Would @dbnicholson or @cgwalters be able to take a look at the ostree surgery parts of this? It's a Rust version of some utterly crazy stuff we have in Endless OS which I made for renaming Flatpaks locally, using an in-memory mtree to commit updated metadata/etc files which have the app ID changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks sane to me, just some completely optional suggestions/notes
4840392
to
0b3bd89
Compare
Pushed some changes:
|
0b3bd89
to
75772c2
Compare
@jameswestman Mind regenerating Cargo.lock after a rebase? |
If this configuration option is present, this endpoint will be used to get information about each app when it is uploaded. It can be used to validate or modify appstream files and to set the token type of the commit.
75772c2
to
8ba936a
Compare
If this configuration option is present, this endpoint will be used to get information about each app when it is uploaded. It can be used to validate or modify appstream files and to set the token type of the commit.
Depends on #69.