Add GetRealPath to document portal

data/org.freedesktop.portal.Documents.xml

@@ -273,5 +273,21 @@
       <arg type='s' name='app_id' direction='in'/>
       <arg type='a{say}' name='docs' direction='out'/>
     </method>
+
+    <!--
+        GetRealPath:
+        @doc_id: the ID of the file in the document store
+        @path: the path for the file in the host filesystem
+
+        Gets the filesystem path for a document store entry.
+
+        This call is available inside the sandbox, if the application has the permission for the document.
+
+        This method was added in version 5 of this interface.
+    -->
+    <method name="GetRealPath">
+      <arg type='as' name='doc_id' direction='in'/>
+      <arg type='aay' name='path' direction='out'/>
+    </method>
   </interface>
 </node>

document-portal/document-portal.c

@@ -1416,6 +1416,90 @@ portal_list (GDBusMethodInvocation *invocation,
   return TRUE;
 }
 
+const char *
+get_real_path_internal (GDBusMethodInvocation *invocation,
+             XdpAppInfo *app_info,
+             const char *id)
+{
+  g_autoptr(PermissionDbEntry) entry = NULL;
+
+  XDP_AUTOLOCK (db);
+
+  entry = permission_db_lookup (db, id);
+
+  if (!entry)
+    {
+      g_dbus_method_invocation_return_error (invocation,
+                                             XDG_DESKTOP_PORTAL_ERROR, XDG_DESKTOP_PORTAL_ERROR_INVALID_ARGUMENT,
+                                            g_strdup_printf("Invalid ID passed (%s)", id));
+      return NULL;
+    }
+
+  if (!xdp_app_info_is_host (app_info))
+    {
+      g_autofree const char **apps = NULL;
+      const char *app_id = NULL;
+      gboolean app_found = FALSE;
+      int i;
+
+      app_id = xdp_app_info_get_id(app_info);
+
+      apps = permission_db_entry_list_apps (entry);
+      for (i = 0; apps[i] != NULL; i++)
+        {
+          if (g_strcmp0 (app_id, apps[i]) == 0)
+            {
+              app_found = TRUE;
+              break;
+            }
+        }
+
+      if (!app_found)
+        {
+          g_dbus_method_invocation_return_error (invocation,
+                                                 XDG_DESKTOP_PORTAL_ERROR, XDG_DESKTOP_PORTAL_ERROR_NOT_ALLOWED,
+                                                 "Not enough permissions");
+          return NULL;
+        }
+    }
+
+  g_autoptr (GVariant) data = permission_db_entry_get_data (entry);
+  const char *path;
+
+  g_variant_get (data, "(^&ayttu)", &path, NULL, NULL, NULL);
+
+  return path;
+}
+
+static gboolean
+portal_get_real_path (GDBusMethodInvocation *invocation,
+             GVariant *parameters,
+             XdpAppInfo *app_info)
+{
+  g_autofree const char **id_list = NULL;
+  const char *path;
+  int i;
+
+  g_variant_get (parameters, "(^a&s)", &id_list);
+
+  GVariantBuilder builder = G_VARIANT_BUILDER_INIT (G_VARIANT_TYPE ("aay"));
+
+  for (i = 0; id_list[i]; i++)
+    {
+      path = get_real_path_internal(invocation, app_info, id_list[i]);
+      if (path == NULL) 
+        {
+          return FALSE;
+        }
+
+      g_variant_builder_add (&builder, "^ay", path);
+    }
+
+  g_dbus_method_invocation_return_value (invocation, g_variant_new ("(aay)", &builder));
+
+  return TRUE;
+}
+
 static void
 peer_died_cb (const char *name)
 {
@@ -1432,7 +1516,7 @@ on_bus_acquired (GDBusConnection *connection,
 
   dbus_api = xdp_dbus_documents_skeleton_new ();
 
-  xdp_dbus_documents_set_version (XDP_DBUS_DOCUMENTS (dbus_api), 4);
+  xdp_dbus_documents_set_version (XDP_DBUS_DOCUMENTS (dbus_api), 5);
 
   g_signal_connect_swapped (dbus_api, "handle-get-mount-point", G_CALLBACK (handle_get_mount_point), NULL);
   g_signal_connect_swapped (dbus_api, "handle-add", G_CALLBACK (handle_method), portal_add);
@@ -1445,6 +1529,7 @@ on_bus_acquired (GDBusConnection *connection,
   g_signal_connect_swapped (dbus_api, "handle-lookup", G_CALLBACK (handle_method), portal_lookup);
   g_signal_connect_swapped (dbus_api, "handle-info", G_CALLBACK (handle_method), portal_info);
   g_signal_connect_swapped (dbus_api, "handle-list", G_CALLBACK (handle_method), portal_list);
+  g_signal_connect_swapped (dbus_api, "handle-get-real-path", G_CALLBACK (handle_method), portal_get_real_path);
 
   file_transfer = file_transfer_create ();
   g_dbus_interface_skeleton_set_flags (file_transfer,

tests/test-doc-portal.c

@@ -687,6 +687,38 @@ test_add_named (void)
   assert_doc_not_exist (id1, basename1, "com.test.App2");
 }
 
+static void
+test_get_real_path (void)
+{
+  g_autofree char *doc_id = NULL;
+  g_autofree char *expected_real_path = NULL;
+  g_autofree char *real_path = NULL;
+  const char *basename = "real-path";
+  g_autoptr(GVariant) reply = NULL;
+  GError *error = NULL;
+
+  if (!check_fuse_or_skip_test ())
+    return;
+
+  doc_id = export_new_file (basename, "content", FALSE);
+
+  reply = g_dbus_connection_call_sync (session_bus,
+                                       "org.freedesktop.portal.Documents",
+                                       "/org/freedesktop/portal/documents",
+                                       "org.freedesktop.portal.Documents",
+                                       "GetRealPath",
+                                       g_variant_new ("(s)", doc_id),
+                                       G_VARIANT_TYPE ("(s)"),
+                                       0, -1,
+                                       NULL,
+                                       &error);
+
+  g_assert_no_error (error);
+  g_variant_get (reply, "(s)", &real_path);
+  expected_real_path = g_build_filename (outdir, basename, NULL);
+  g_assert_cmpstr (real_path, ==, expected_real_path);
+}
+
 static void
 global_setup (void)
 {
@@ -853,7 +885,7 @@ test_version (void)
   if (!check_fuse_or_skip_test ())
     return;
 
-  g_assert_cmpint (xdp_dbus_documents_get_version (documents), ==, 4);
+  g_assert_cmpint (xdp_dbus_documents_get_version (documents), ==, 5);
 }
 
 int
@@ -871,6 +903,7 @@ main (int argc, char **argv)
   g_test_add_func ("/db/recursive_doc", test_recursive_doc);
   g_test_add_func ("/db/create_docs", test_create_docs);
   g_test_add_func ("/db/add_named", test_add_named);
+  g_test_add_func ("/db/get_real_path", test_get_real_path);
 
   global_setup ();