Port the app chooser portal #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename org.freedesktop.portal.AppChooser to org.freedesktop.portal.OpenURI and redo the implementation along the same lines as the file chooser portal. We use the new app chooser interface provided by the gtk backend. More of the work is now done in the frontend: listing suitable applications, and launching the chosen one. The backend provides a simple chooser UI.
agx
pushed a commit
to agx/xdg-desktop-portal
that referenced
this pull request
Dec 20, 2023
Be more careful with labels
whot
added a commit
to whot/xdg-desktop-portal
that referenced
this pull request
Feb 8, 2024
g_proxy_resolver_get_default() via g_proxy_resolver_gnome_init() fails hard if the XDG_DATA_DIR isn't set because the GSettings cannot be found: In particular this statement fails: resolver->proxy_settings = g_settings_new (GNOME_PROXY_SETTINGS_SCHEMA); (gdb) bt #0 0x00007ffff7eb9bef in g_log_structured_array () at /lib64/libglib-2.0.so.0 flatpak#1 0x00007ffff7eb9edc in g_log_default_handler () at /lib64/libglib-2.0.so.0 flatpak#2 0x00007ffff7eba180 in g_logv () at /lib64/libglib-2.0.so.0 flatpak#3 0x00007ffff7eba463 in g_log () at /lib64/libglib-2.0.so.0 flatpak#4 0x00007ffff7d7b952 in g_settings_set_property () at /lib64/libgio-2.0.so.0 flatpak#5 0x00007ffff7c4775a in object_set_property () at /lib64/libgobject-2.0.so.0 flatpak#6 0x00007ffff7c48068 in g_object_new_internal.part () at /lib64/libgobject-2.0.so.0 flatpak#7 0x00007ffff7c4a1a3 in g_object_new_valist () at /lib64/libgobject-2.0.so.0 flatpak#8 0x00007ffff7c4a55f in g_object_new () at /lib64/libgobject-2.0.so.0 flatpak#9 0x00007ffff7fb4ac4 in g_proxy_resolver_gnome_init () at /usr/lib64/gio/modules/libgiognomeproxy.so flatpak#10 0x00007ffff7c625ea in g_type_create_instance () at /lib64/libgobject-2.0.so.0 flatpak#11 0x00007ffff7c47fb4 in g_object_new_internal.part () at /lib64/libgobject-2.0.so.0 flatpak#12 0x00007ffff7c495d6 in g_object_new_with_properties () at /lib64/libgobject-2.0.so.0 flatpak#13 0x00007ffff7c4a581 in g_object_new () at /lib64/libgobject-2.0.so.0 flatpak#14 0x00007ffff7d03c6c in try_implementation () at /lib64/libgio-2.0.so.0 flatpak#15 0x00007ffff7d09e8e in _g_io_module_get_default () at /lib64/libgio-2.0.so.0 flatpak#16 0x00007ffff7d18d2a in g_proxy_resolver_get_default () at /lib64/libgio-2.0.so.0 flatpak#17 0x00000000004d4083 in proxy_resolver_init (resolver=0x5a6cc0) at ../src/proxy-resolver.c:99 This causes xdp to abort, it never claims the bus and our tests time out.
whot
added a commit
to whot/xdg-desktop-portal
that referenced
this pull request
Feb 8, 2024
g_proxy_resolver_get_default() via g_proxy_resolver_gnome_init() fails hard if the XDG_DATA_DIR isn't set because the GSettings cannot be found: In particular this statement fails: resolver->proxy_settings = g_settings_new (GNOME_PROXY_SETTINGS_SCHEMA); (gdb) bt #0 0x00007ffff7eb9bef in g_log_structured_array () at /lib64/libglib-2.0.so.0 flatpak#1 0x00007ffff7eb9edc in g_log_default_handler () at /lib64/libglib-2.0.so.0 flatpak#2 0x00007ffff7eba180 in g_logv () at /lib64/libglib-2.0.so.0 flatpak#3 0x00007ffff7eba463 in g_log () at /lib64/libglib-2.0.so.0 flatpak#4 0x00007ffff7d7b952 in g_settings_set_property () at /lib64/libgio-2.0.so.0 flatpak#5 0x00007ffff7c4775a in object_set_property () at /lib64/libgobject-2.0.so.0 flatpak#6 0x00007ffff7c48068 in g_object_new_internal.part () at /lib64/libgobject-2.0.so.0 flatpak#7 0x00007ffff7c4a1a3 in g_object_new_valist () at /lib64/libgobject-2.0.so.0 flatpak#8 0x00007ffff7c4a55f in g_object_new () at /lib64/libgobject-2.0.so.0 flatpak#9 0x00007ffff7fb4ac4 in g_proxy_resolver_gnome_init () at /usr/lib64/gio/modules/libgiognomeproxy.so flatpak#10 0x00007ffff7c625ea in g_type_create_instance () at /lib64/libgobject-2.0.so.0 flatpak#11 0x00007ffff7c47fb4 in g_object_new_internal.part () at /lib64/libgobject-2.0.so.0 flatpak#12 0x00007ffff7c495d6 in g_object_new_with_properties () at /lib64/libgobject-2.0.so.0 flatpak#13 0x00007ffff7c4a581 in g_object_new () at /lib64/libgobject-2.0.so.0 flatpak#14 0x00007ffff7d03c6c in try_implementation () at /lib64/libgio-2.0.so.0 flatpak#15 0x00007ffff7d09e8e in _g_io_module_get_default () at /lib64/libgio-2.0.so.0 flatpak#16 0x00007ffff7d18d2a in g_proxy_resolver_get_default () at /lib64/libgio-2.0.so.0 flatpak#17 0x00000000004d4083 in proxy_resolver_init (resolver=0x5a6cc0) at ../src/proxy-resolver.c:99 This causes xdp to abort, it never claims the bus and our tests time out.
whot
added a commit
to whot/xdg-desktop-portal
that referenced
this pull request
Feb 8, 2024
g_proxy_resolver_get_default() via g_proxy_resolver_gnome_init() fails hard if the XDG_DATA_DIR isn't set because the GSettings cannot be found: In particular this statement fails: resolver->proxy_settings = g_settings_new (GNOME_PROXY_SETTINGS_SCHEMA); (gdb) bt #0 0x00007ffff7eb9bef in g_log_structured_array () at /lib64/libglib-2.0.so.0 flatpak#1 0x00007ffff7eb9edc in g_log_default_handler () at /lib64/libglib-2.0.so.0 flatpak#2 0x00007ffff7eba180 in g_logv () at /lib64/libglib-2.0.so.0 flatpak#3 0x00007ffff7eba463 in g_log () at /lib64/libglib-2.0.so.0 flatpak#4 0x00007ffff7d7b952 in g_settings_set_property () at /lib64/libgio-2.0.so.0 flatpak#5 0x00007ffff7c4775a in object_set_property () at /lib64/libgobject-2.0.so.0 flatpak#6 0x00007ffff7c48068 in g_object_new_internal.part () at /lib64/libgobject-2.0.so.0 flatpak#7 0x00007ffff7c4a1a3 in g_object_new_valist () at /lib64/libgobject-2.0.so.0 flatpak#8 0x00007ffff7c4a55f in g_object_new () at /lib64/libgobject-2.0.so.0 flatpak#9 0x00007ffff7fb4ac4 in g_proxy_resolver_gnome_init () at /usr/lib64/gio/modules/libgiognomeproxy.so flatpak#10 0x00007ffff7c625ea in g_type_create_instance () at /lib64/libgobject-2.0.so.0 flatpak#11 0x00007ffff7c47fb4 in g_object_new_internal.part () at /lib64/libgobject-2.0.so.0 flatpak#12 0x00007ffff7c495d6 in g_object_new_with_properties () at /lib64/libgobject-2.0.so.0 flatpak#13 0x00007ffff7c4a581 in g_object_new () at /lib64/libgobject-2.0.so.0 flatpak#14 0x00007ffff7d03c6c in try_implementation () at /lib64/libgio-2.0.so.0 flatpak#15 0x00007ffff7d09e8e in _g_io_module_get_default () at /lib64/libgio-2.0.so.0 flatpak#16 0x00007ffff7d18d2a in g_proxy_resolver_get_default () at /lib64/libgio-2.0.so.0 flatpak#17 0x00000000004d4083 in proxy_resolver_init (resolver=0x5a6cc0) at ../src/proxy-resolver.c:99 This causes xdp to abort, it never claims the bus and our tests time out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename org.freedesktop.portal.AppChooser to org.freedesktop.portal.OpenURI
and redo the implementation along the same lines as the file chooser
portal. We use the new app chooser interface provided by the gtk
backend. More of the work is now done in the frontend: listing suitable
applications, and launching the chosen one. The backend provides a
simple chooser UI.