-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure.md5 hashing with MD5 is not FIPS compliant #78
Comments
One option using a SHA256: Another option not using any digest: |
larskanis
added a commit
to larskanis/mini_portile
that referenced
this issue
May 31, 2017
MD5 is no longer available in environments with strict security settings especially when running in FIPS mode. Fixes flavorjones#78
larskanis
added a commit
to larskanis/mini_portile
that referenced
this issue
May 31, 2017
MD5 is no longer available in environments with strict security settings especially when running in FIPS mode. Fixes flavorjones#78
larskanis
added a commit
to larskanis/mini_portile
that referenced
this issue
May 31, 2017
MD5 is no longer available in environments with strict security settings especially when running in FIPS mode. Fixes flavorjones#78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like an MD5 digest is used in
MiniPortile#configure
andMiniPortile#configured?
. It looks like security is not a concern given what it's used for. However, this will fail on an OS running in FIPS mode as MD5 is not an accepted digest algorithm. One option is to use a supported algorithm, such asDigest::SHA256
, but that may not even be necessary as you might even be okay to usecomputed_options.to_s
without hashing it. Thoughts?For reference, the failure can be demonstrated on a FIPS-enabled system as follows:
The text was updated successfully, but these errors were encountered: