fix: source_directory option on windows #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because autoconf "configure" scripts get confused on windows
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
source_directorybehavior to use a posix path internally, because autoconfconfigurescripts get confused when presented with a windows path.So if the windows path to the source directory is
D:\temp\project, the configure script will be invoked as/D/temp/project/configureso that detection of aux files will properly look in the script's directory.Also, this PR updates the behavior on failure to output the complete log (not just the last 20 lines), and additionally will output the entire contents of
config.logfrom the configure step.