Add a maximum allocation size when decoding #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
Upon bogus input data, decoding could allocate an insane amount of
memory (if length field is misencoded to a huge number) and panic.
To avoid this behaviour, this change introduces a limit (default 512MB)
to any allocation that can be done when decoding data.
Also return errors when decoding bogus int/long causing overflows.
Benchmark don't seem impacted by the change
make lint
decided to change a bunch of stuff. Changes don't look terrible :)