Inconsistent null-aware behaviour in moveAndRotate

[OfficiallySomeGuy]

Noticed this minor issue that I have patched locally -- id is marked (I believe correctly) as an optional parameter, however the null-aware ! operator is then used to perform a null-check.

In the underlying move and rotate functions, id is not mandatory, and as a keyword arg it seems sensible that this operator were not used in this context.

Surely in this case, we should either enforce id as a required parameter everywhere, or, in my view preferably, remove the null-safe check.

flutter_map/lib/src/map/map.dart

Line 36 in f19cce5

source: MapEventSource.mapController, id: id!);

Will open a PR, but opening this issue also for discussion, as not entirely familiar with the codebase.

[JaffaKetchup]

This has been causing issues for me too ("null check operator used on null value"), and as id should be optional, your PR is the right way of doing things, I think.

[tlueder]

Same for me, this broke my app and it took me a while to find the cause.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[OfficiallySomeGuy]

Resolved in #1022