Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI indexed nfa view #230

Merged
merged 21 commits into from
Apr 20, 2023
Merged

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Apr 18, 2023

Screen.Recording.2023-04-19.at.17.11.20.mov

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #824: UI: indexed NFA view.

@zoruka zoruka self-assigned this Apr 18, 2023
@zoruka zoruka added enhancement New feature or request frontend Frontend task labels Apr 18, 2023
@zoruka zoruka requested a review from csosamorales April 19, 2023 20:14
@zoruka zoruka marked this pull request as ready for review April 19, 2023 20:14
ui/src/components/nfa-card/nfa-card.tsx Outdated Show resolved Hide resolved
const { nfa } = IndexedNFA.useContext();

const color = useMemo(
// TODO: replace with util function

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we gonna do this on this PR or separate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is better let this for a future PR as you have already added the util function with #223, right?

@zoruka zoruka merged commit 22a6d70 into develop Apr 20, 2023
@zoruka zoruka deleted the feature/sc-824/ui-indexed-nfa-view branch April 20, 2023 17:19
csosamorales pushed a commit that referenced this pull request Apr 28, 2023
* feat: UI indexed nfa view (#230)

* wip: indexed nfa base layout

* refactor: split aside and main components to single files

* feat: indexed nfa aside styling

* feat: add main section header and drescription

* feat: add main section traits

* feat: add verification banner in main fragment

* feat: add externla link icon

* feat: add table stylings and frontends section mocked

* feat: add versions table mocked

* feat: add small layer of responsivity

* feat: add indexed nfa view skeleton

* refactor: create fragments folder

* refactor: split out mock and add todo comment

* feat: add icon on verified banner

* refactor: table stylings

* feat: add chevron right icon

* fix: link paths

* chore: add todo comments

* refactor: set initial position for aside container

* refactor: improve spacings

* fix: remove leftover comment

* feat: UI ap flow (#223)

* chore: AP flow based on designs

* chore: preview ap creation

* style: max-width for explore container

* fix: fix setArgs

* feat: add success step for access point creation

* feat: add dots spinner

* chore: AP flow finished

* chore: release changes

* feat: store ens once the user log in with wallet

* feat: add mocked function for bunny cdn creation

* chore: finish bunny cdn mocked functions

* chore: run eslint

* feat: add domain validator

* style: move animation to stitches keyframes

* chore: set ens only when is not set

* Update ui/src/store/features/bunny-cdn/async-thunk/verify-ap.ts

Co-authored-by: Felipe Mendes <[email protected]>

* chore: remove nfa-picker

* chore: get nfa name

* chore: change verify thunk name

* fix: fix verifyPullzone thunk

---------

Co-authored-by: Felipe Mendes <[email protected]>

* refactor: ui explore view responsivity (#236)

* refactor: clean up nfa search code and add base responsivity

* refactor: clean up nfa list code

* refactor: rename explore header fragment files

* refactor: nfa list items sizing

* feat: add vertical padding for page content

* refactor: make navbar not break the layout

* styles: fix dropdown sorting styles (#238)

* feat: serverless new mint handler placeholder (#221)

* feat: add handler.

* fix: make the handler compilable.

* feat: parse json

* bug: contract verifier address sent on mint calls (#239)

* chore: update hardhat to fix viaIR issues

* feat: add validations in main contract

* refactor: add hardhat tests

* test: add foundry tests

---------

Co-authored-by: Felipe Mendes <[email protected]>
Co-authored-by: Shredder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Frontend task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants