Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: UI remove tailwind from input component #241

Merged

Conversation

csosamorales
Copy link

  • removed tailwind from Input component
  • added InputGroup
  • added styles file for GithubRepositorySelection component

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #830: UI: remove tailwind from Input component.

@csosamorales csosamorales requested review from zoruka April 24, 2023 19:44
Comment on lines 19 to 21
type InputGroupProps = {
children: React.ReactNode;
} & React.ComponentPropsWithRef<typeof InputGroupStyled>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type InputGroupProps = {
children: React.ReactNode;
} & React.ComponentPropsWithRef<typeof InputGroupStyled>;
type InputGroupProps = React.ComponentPropsWithRef<typeof InputGroupStyled>;

Comment on lines 23 to 24
export const InputGroup = forwardStyledRef<HTMLDivElement, InputGroupProps>(
({ children, ...props }, ref) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const InputGroup = forwardStyledRef<HTMLDivElement, InputGroupProps>(
({ children, ...props }, ref) => {
export const InputGroup = InputGroupStyled;

@csosamorales csosamorales merged commit fd4b7c9 into develop Apr 27, 2023
@csosamorales csosamorales deleted the chore/sc-830/ui-remove-tailwind-from-input-component branch April 27, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants