Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Deploy Fleet website" GitHub action failing #22931

Closed
eashaw opened this issue Oct 15, 2024 · 3 comments · Fixed by #22939
Closed

"Deploy Fleet website" GitHub action failing #22931

eashaw opened this issue Oct 15, 2024 · 3 comments · Fixed by #22939
Assignees
@eashaw
Labels
bug Something isn't working as documented #g-digital-experience https://fleetdm.com/handbook/digital-experience ~website Issues related to fleetdm.com

Comments

@eashaw
Copy link
Contributor

eashaw commented Oct 15, 2024

Issue/Goal:

The deploy Fleet website GitHub action is currently failing on the Run heroku auth:whoami step with this error:

Run heroku auth:whoami
  heroku auth:whoami
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
/home/runner/work/_temp/6ff89384-c719-4978-b0a0-9044e30b298.sh: line 1: heroku: command not found
Error: Process completed with exit code 127.
@eashaw eashaw added bug Something isn't working as documented #g-digital-experience https://fleetdm.com/handbook/digital-experience ~website Issues related to fleetdm.com labels Oct 15, 2024
@eashaw eashaw self-assigned this Oct 15, 2024
@eashaw
Copy link
Contributor Author

eashaw commented Oct 15, 2024

I confirmed that the pinned version of the Heroku deploy GH action is working as expected by adding the pinned versions to another app's deploy script.
@lukeheath Do you know if there was a configuration change in the Fleet Repo that would be causing this?

@eashaw eashaw mentioned this issue Oct 15, 2024
Merged
eashaw added a commit that referenced this issue Oct 15, 2024
@eashaw
Test vulnerability dashboard deploy workflow (#22938)
413c2bb 
Related to: #22931

Changes:
- made a minor whitespace change to trigger a redeploy of the
vulnerability dashboard to see if it is affected by the same issue as
the "Deploy Fleet website" workflow.
@eashaw
Copy link
Contributor Author

eashaw commented Oct 15, 2024

It looks like this is being caused by the ubuntu version that the workflow is running on. I tested changing the version in my app's deploy script from ubuntu-20.04 to ubuntu-latest and that made it fail with the same error.
I will make a PR to change the version to the latest version of ubuntu that the Heroku GH action is compatible with.

@eashaw eashaw mentioned this issue Oct 15, 2024
Merged
eashaw added a commit that referenced this issue Oct 15, 2024
@eashaw
Change Ubuntu version in Heroku deploy workflows (#22939)
cb67c32 
Closes: #22931

Changes:
- Updated the deploy workflows for the Fleet website and the
vulnerability dashboard to run on Ubuntu 22.04 to prevent issues we've
been seeing with the Heroku deploy action and the latest version of
Ubuntu.
@fleet-release
Copy link
Contributor

Heroku step stumbles,
Fleet's site can't take flight, yet,
Fix brings dawn's light, warm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eashaw eashaw

Labels
bug Something isn't working as documented #g-digital-experience https://fleetdm.com/handbook/digital-experience ~website Issues related to fleetdm.com
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Ubuntu version in Heroku deploy workflows fleetdm/fleet
2 participants
@eashaw @fleet-release