Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken form validation when enabling SSO #25264

Open
1 of 3 tasks
jacobshandling opened this issue Jan 8, 2025 · 0 comments
Open
1 of 3 tasks

Broken form validation when enabling SSO #25264

jacobshandling opened this issue Jan 8, 2025 · 0 comments
Assignees
@jacobshandling
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-orchestration Orchestration product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.63.0

Comments

@jacobshandling
Copy link
Contributor

jacobshandling commented Jan 8, 2025 •
edited
Loading

Fleet version: 4.61.0

💥  Actual behavior

Same as #25009, but when enabling SSO:

User can save SSO form after checking "Enable single sign-on", even with required fields not filled in. The API call fails.

Screenshot 2025-01-08 at 12 03 55 PM

🧑‍💻  Steps to reproduce

Same as 25009, but for enabling sso

🛠️ To fix

  • Validate form fields on change, on blur, and on submit, so the user cannot submit the form until all required fields are present and valid

QA

  • Disable SSO if it's enabled, and remove all values from the form, save, refresh.
  • Check "Enable single sign-on"
  • Confirm:
  • Clicking "Save" causes error states to appear, and does not try to submit the form
  • Filling in required fields then enables saving the form
@jacobshandling jacobshandling added #g-orchestration Orchestration product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. :reproduce Involves documenting reproduction steps in the issue bug Something isn't working as documented ~frontend Frontend-related issue. and removed :reproduce Involves documenting reproduction steps in the issue :incoming New issue in triage process. labels Jan 8, 2025
@jacobshandling jacobshandling self-assigned this Jan 9, 2025
@jacobshandling jacobshandling mentioned this issue Jan 10, 2025
Open
@jacobshandling jacobshandling added this to the 4.63.0-tentative milestone Jan 10, 2025
@lukeheath lukeheath added the ~released bug This bug was found in a stable release. label Jan 10, 2025
@jacobshandling jacobshandling mentioned this issue Jan 13, 2025
Merged
3 tasks
jacobshandling added a commit that referenced this issue Jan 13, 2025
@jacobshandling
UI - Update validation pattern on SSO settings form (#25387)
8c4275a 
## For #25264 


https://github.com/user-attachments/assets/031f3636-3c0e-4439-969d-716cb08b2449

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobshandling jacobshandling

Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-orchestration Orchestration product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.63.0
Development

No branches or pull requests
2 participants
@lukeheath @jacobshandling