Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Clean up colors.ts and colors.scss #25665

Open
3 tasks
RachelElysia opened this issue Jan 22, 2025 · 1 comment
Open
3 tasks

FE: Clean up colors.ts and colors.scss #25665

RachelElysia opened this issue Jan 22, 2025 · 1 comment
Labels
~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. :incoming New issue in triage process. :product Product Design department (shows up on 🦢 Drafting board) :refactor Involves refactoring. Shouldn't add/change functionality. May improve contributor experience.

Comments

@RachelElysia
Copy link
Member

RachelElysia commented Jan 22, 2025

Fleet version:

Web browser and operating system:


💥  Actual behavior

There is one color #6A67FE that is represented by "core-fleet-blue" in colors.ts but represented by "ui-info" AND "core-vibrant-blue" in colors.scss

The colors are hard to understand by name and might have old color schemes mixed with new color schemes

🕯️ More info

The dev experience isn't great (e.g. @iansltx was reviewing a PR (ticket #25257) that updates dropdown state colors and he had a hard time understanding which color was what)

🛠️ To fix

  • Have a designer define all the colors used and the names of them all
  • Have a designer define those colors in Figma
  • Have a frontend developer update all colors on colors.ts and colors.scss and throughout the app to match the proper names
@RachelElysia RachelElysia added :incoming New issue in triage process. :product Product Design department (shows up on 🦢 Drafting board) :refactor Involves refactoring. Shouldn't add/change functionality. May improve contributor experience. ~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. labels Jan 22, 2025
@parsimeikoikai
Copy link
Contributor

@RachelElysia I am ready and willing to help with this task once the designer has defined those colors in Figma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. :incoming New issue in triage process. :product Product Design department (shows up on 🦢 Drafting board) :refactor Involves refactoring. Shouldn't add/change functionality. May improve contributor experience.
Development

No branches or pull requests

2 participants