-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet UI: Selected dropdown color #25257
Comments
@RachelElysia What do you think about using the hover color for previously selected, but as you roll over things, only what you're rolling over has the color (i.e. the previously selected item becomes unselected), and if you roll off then the previously selected is shown so we don't have a situation where we're showing two selected things at once? I feel like we don't need a persistent selected state as it's already shown, and this also means we don't have to have multiple or competing colors in the dropdown. Does that make sense? I'm trying to find an example to illustrate in case the words are failing. |
Reproduced on 4.62.0 - Will this unify all drop downs in fleet or only the ones mentioned in the ticket? |
@jmwatts Ideally I'd love it if it would unify all dropdowns in fleet. I think @RachelElysia suggested something similar when she mentioned it would take her a little time to dig out all the instances? |
Yeah, per our convo today:
|
@rachaelshaw & @marko-lisica : Perkins has pointed out that we have inconsistent behaviors in our dropdowns wrt selected states and rollovers, and Janis mentioned that using solely a color indicator isn't great for accessibility. So I have a proposal that includes the following:
Examples:
Thoughts? |
@eugkuo Thanks for the prototypes! This looks way better to me. I like bold for the active state, it rally makes it easy to know which one is active that way. I personally wouldn't use bold on hover, as the text jumps and feels a bit buggy. I found this Figma from Mike T. here. He distinguished hover and active states with different colors (gray and purple). Also items on hover and when active have rounded corners which I think is a nice detail. It's consistent with the rounded corners of the dropdown. |
Hello again. Based on @marko-lisica's feedback I've done alternate versions of the prototypes removing the bold on rollover and re-introducing a down state:
A few notes:
@rachaelshaw @noahtalerman @RachelElysia Thoughts? |
|
@jmwatts I think having selected items bolded could help. Bolded text would be an additional indicator besides color change. |
@marko-lisica I did do that in the last prototype I sent. However, it doesn't solve the rollover problem. I'm still advocating for my the first iteration of the design where the rollover and down state are the same, and the downstate clears on rollover. The rollover and down states use both color and bold to indicate the selection/rollover. |
+1 bold on active state, it would match the bold on our active tabs |
Thanks for everyone's input. Let's go with the original proposal. The selected and hover state are the same, and the selected state is released when hovering on other items in the list so that we don't have competing states in the dropdown. The selected/hover state retains the purple background but also bolds the text for accessibility. The corners are also now rounded. I've updated to add this to the To fix area and also added an example of the 'Filter by platform or label' dropdown. I do believe a future improvement will be to separate this into two filters. |
Please add your planning poker estimate with Zenhub @RachelElysia |
@RachelElysia Updated links per our discussion: |
Fleet version:
dogfood so 4.62
Web browser and operating system:
💥 Actual behavior
We have 3 different previously selected colors going on: 1. hover purple for previously selected, dark purple for previously selected, light blue for previously selected. For each of these screenshots, one is a hover color, the other is an option that is currently selected.
🧑💻 Steps to reproduce
🕯️ More info (optional)
Need design to specify what color a previously selected dropdown option should be
🛠️ To fix
QA Plan
Dropdown
react-select 1.3.0 dropdownsDropdownWrapper
react-select 5.4.0 dropdownsThe text was updated successfully, but these errors were encountered: