-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added signed URLs #25197
Added signed URLs #25197
Conversation
…to victor/24869-signed-urls
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25197 +/- ##
==========================================
- Coverage 63.85% 63.84% -0.01%
==========================================
Files 1617 1617
Lines 153841 153965 +124
Branches 4032 4032
==========================================
+ Hits 98231 98304 +73
- Misses 47794 47838 +44
- Partials 7816 7823 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for the link to the article!
For #24869
This subtask contains code to sign the CloudFront software installer and bootstrap package URL using AWS SDK URL signer.
It works with the current bootstrap package delivery. For software installers, fleetd will need to be modified to take advantage of this URL in a future subtask (which will also include updated API contributor docs).
My article on signed URLs, for context: https://victoronsoftware.com/posts/cloudfront-signed-urls/
Checklist for submitter