Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added signed URLs #25197

Merged
merged 12 commits into from
Jan 9, 2025
Merged

Added signed URLs #25197

merged 12 commits into from
Jan 9, 2025

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Jan 7, 2025

For #24869

This subtask contains code to sign the CloudFront software installer and bootstrap package URL using AWS SDK URL signer.
It works with the current bootstrap package delivery. For software installers, fleetd will need to be modified to take advantage of this URL in a future subtask (which will also include updated API contributor docs).

My article on signed URLs, for context: https://victoronsoftware.com/posts/cloudfront-signed-urls/

Checklist for submitter

  • Added/updated automated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 64.70588% with 66 lines in your changes missing coverage. Please review.

Project coverage is 63.84%. Comparing base (7e1a808) to head (9bc0bc9).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
cmd/fleet/serve.go 0.00% 16 Missing ⚠️
server/worker/apple_mdm.go 62.50% 10 Missing and 2 partials ⚠️
server/datastore/s3/common_file_store.go 35.71% 6 Missing and 3 partials ⚠️
server/mdm/cryptoutil/cryptoutil.go 78.37% 6 Missing and 2 partials ⚠️
server/config/config.go 63.15% 6 Missing and 1 partial ⚠️
cmd/fleet/cron.go 0.00% 4 Missing ⚠️
ee/server/service/software_installers.go 91.89% 2 Missing and 1 partial ⚠️
server/datastore/filesystem/software_installer.go 0.00% 2 Missing ⚠️
server/fleet/errors.go 0.00% 2 Missing ⚠️
server/fleet/software_installer.go 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25197      +/-   ##
==========================================
- Coverage   63.85%   63.84%   -0.01%     
==========================================
  Files        1617     1617              
  Lines      153841   153965     +124     
  Branches     4032     4032              
==========================================
+ Hits        98231    98304      +73     
- Misses      47794    47838      +44     
- Partials     7816     7823       +7     
Flag Coverage Δ
backend 64.72% <64.70%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor marked this pull request as ready for review January 7, 2025 23:22
@getvictor getvictor requested a review from a team as a code owner January 7, 2025 23:22
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the link to the article!

@getvictor getvictor merged commit 68b7cf9 into main Jan 9, 2025
18 of 19 checks passed
@getvictor getvictor deleted the victor/24869-signed-urls branch January 9, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants