Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress CSS and JS with gzip before serving to reduce load time/page weight #25658

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Jan 22, 2025

For #24732.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link
Contributor

@ksykulev ksykulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@iansltx iansltx merged commit 26de929 into main Jan 22, 2025
29 checks passed
@iansltx iansltx deleted the 24732-gzip branch January 22, 2025 02:15
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.58%. Comparing base (41e8324) to head (6e74b01).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/service/frontend.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25658      +/-   ##
==========================================
- Coverage   63.59%   63.58%   -0.02%     
==========================================
  Files        1622     1622              
  Lines      155115   155122       +7     
  Branches     4055     4055              
==========================================
- Hits        98648    98636      -12     
- Misses      48696    48712      +16     
- Partials     7771     7774       +3     
Flag Coverage Δ
backend 64.44% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants