Terraform why this way #25746
Merged
Terraform why this way #25746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeheath
reviewed
Jan 27, 2025
|
@rfairburn This looks good to me with the suggested edit. I'm tagging @noahtalerman for visibility. Ultimately this will need @mikermcneil's approval, which may take a few days. I'll bring to e-group on Wednesday if it isn't reviewed by then. I'm adding a summary in the PR description explaining why we're making this change. |
Co-authored-by: Luke Heath <[email protected]>
|
@lukeheath thanks. I committed your recommendation and moved the PR into "Ready for Review" |
lukeheath
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Approved by me, will need @mikermcneil's approval as DRI for the page before we create the repo.
|
@Sampfluger88 Tagging you to get it on your radar. |
mikermcneil
approved these changes
Jan 27, 2025
|
Thanks! @rfairburn @zayhanlon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #18191
Why add another repo?
Terraform clones the entire repo for every submodule used when running
terraform init. For our monorepo, that is 11GB, which significantly slows down deployment speed using Terraform. By moving our Terraform modules to a dedicated repo, we reduce this to <1MB, which will shave minutes off ofterraform initfor anyone who uses it. Because our CI deployment runsterraform initon every environment, this will result in savings of several hours of CI runners per month.