Tab visibility (#2213)

* add Tab.visible * fix typo
flet-dev · Dec 7, 2023 · 2bea97a · 2bea97a
1 parent 2981721
commit 2bea97a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/package/lib/src/controls/tabs.dart b/package/lib/src/controls/tabs.dart
@@ -75,6 +75,9 @@ class _TabsControlState extends State<TabsControl>
   Widget build(BuildContext context) {
     debugPrint("TabsControl build: ${widget.control.id}");
 
+    // keep only visible tabs
+    widget.children.retainWhere((c) => c.isVisible);
+
     var tabs = StoreConnector<AppState, ControlsViewModel>(
         distinct: true,
         converter: (store) => ControlsViewModel.fromStore(
@@ -121,12 +124,12 @@ class _TabsControlState extends State<TabsControl>
 
           var indicatorBorderRadius =
               parseBorderRadius(widget.control, "indicatorBorderRadius");
-          var inidicatorBorderSide = parseBorderSide(
-              Theme.of(context), widget.control, "inidicatorBorderSide");
+          var indicatorBorderSide = parseBorderSide(
+              Theme.of(context), widget.control, "indicatorBorderSide");
           var indicatorPadding =
               parseEdgeInsets(widget.control, "indicatorPadding");
 
-          var inidicatorColor = HexColor.fromString(Theme.of(context),
+          var indicatorColor = HexColor.fromString(Theme.of(context),
                   widget.control.attrString("indicatorColor", "")!) ??
               TabBarTheme.of(context).indicatorColor ??
               Theme.of(context).colorScheme.primary;
@@ -148,25 +151,25 @@ class _TabsControlState extends State<TabsControl>
                       : TabBarIndicatorSize.label)
                   : TabBarTheme.of(context).indicatorSize,
               indicator: indicatorBorderRadius != null ||
-                      inidicatorBorderSide != null ||
+                      indicatorBorderSide != null ||
                       indicatorPadding != null
                   ? UnderlineTabIndicator(
                       borderRadius: indicatorBorderRadius ??
                           themeIndicator?.borderRadius ??
                           const BorderRadius.only(
                               topLeft: Radius.circular(2),
                               topRight: Radius.circular(2)),
-                      borderSide: inidicatorBorderSide ??
+                      borderSide: indicatorBorderSide ??
                           themeIndicator?.borderSide ??
                           BorderSide(
                               width: themeIndicator?.borderSide.width ?? 2,
                               color: themeIndicator?.borderSide.color ??
-                                  inidicatorColor),
+                                  indicatorColor),
                       insets: indicatorPadding ??
                           themeIndicator?.insets ??
                           EdgeInsets.zero)
                   : TabBarTheme.of(context).indicator,
-              indicatorColor: inidicatorColor,
+              indicatorColor: indicatorColor,
               labelColor: HexColor.fromString(Theme.of(context), widget.control.attrString("labelColor", "")!) ??
                   TabBarTheme.of(context).labelColor ??
                   Theme.of(context).colorScheme.primary,

diff --git a/sdk/python/packages/flet-core/src/flet_core/tabs.py b/sdk/python/packages/flet-core/src/flet_core/tabs.py
@@ -25,8 +25,9 @@ def __init__(
         tab_content: Optional[Control] = None,
         ref: Optional[Ref] = None,
         icon: Optional[str] = None,
+        visible: Optional[bool] = None,
     ):
-        Control.__init__(self, ref=ref)
+        Control.__init__(self, ref=ref, visible=visible)
         self.text = text
         self.icon = icon
         self.__content: Optional[Control] = None