Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to allow certain build commands according to "build_on" platform. #2343

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

taaaf11
Copy link
Contributor

@taaaf11 taaaf11 commented Jan 8, 2024

Add checks to allow certain build commands according to build on platform according to matrix given at https://flet.dev/docs/guides/python/packaging-app-for-distribution/#build-platform-matrix .

Addresses issue: #2342 .

Edit: Issue number.

@ndonkoHenri ndonkoHenri linked an issue Jan 8, 2024 that may be closed by this pull request
@taaaf11 taaaf11 requested a review from FeodorFitsner January 9, 2024 05:53
@taaaf11 taaaf11 requested a review from FeodorFitsner January 9, 2024 17:37
@FeodorFitsner FeodorFitsner merged commit 88e3f37 into flet-dev:main Jan 9, 2024
2 checks passed
zrr1999 pushed a commit to zrr1999/flet that referenced this pull request Jul 17, 2024
…atform. (flet-dev#2343)

* Add checks to allow certain build commands

Add checks to allow certain build commands according to build on platform according to matrix given at https://flet.dev/docs/guides/python/packaging-app-for-distribution/#build-platform-matrix

* Make platform name more user friendly in platform checks.

* More oop approach

* Apply black formatting

* Fixed bug in checks

* Fix a typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OS check to flet build command to avoid incompatible runs
2 participants