Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reopen] Rename NavigationDestination to NavigationBarDestination + some type hinting, fixes and new features #3172

Merged
merged 29 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
1996ba7
init commit
bleudev May 2, 2024
eb8be46
`page.py` type hinting part 1, `close_snack_bar()`, Snack bar and Dia…
bleudev May 2, 2024
c367427
Fix Inherited
bleudev May 3, 2024
c471da2
Fix `'type' object is not subscriptable`
bleudev May 3, 2024
a36b229
type hinting `page.py` final
bleudev May 3, 2024
e2daae1
`auto_update` + `Page.__contains__()`
bleudev May 3, 2024
3d617fb
add `@deprecated` for`NavigationDestination`, `add()`, `insert()`, `r…
bleudev May 3, 2024
21ee203
Merge branch 'flet-dev:main' into main
bleudev May 3, 2024
8f0326a
`add()`, `remove()`, `inserrt()`: `NavigationDrawer` and `NavigationR…
bleudev May 4, 2024
b5b57d8
`CupertinoNavigationBar`, `View`, `Column`, `Row`
bleudev May 4, 2024
6bed4da
Type hinting `control.py`
bleudev May 4, 2024
ead6ab7
Fix `NameError: name 'Page' is not defined
bleudev May 4, 2024
40943a0
Final `add()`, `insert()`, `remove()`
bleudev May 4, 2024
60d8c7e
type hinting for `cupertino_navigation_bar.py`
bleudev May 4, 2024
15f925a
isort and black formatting
bleudev May 4, 2024
d41b36c
Merge branch 'flet-dev:main' into main
bleudev May 6, 2024
7827737
Merge branch 'flet-dev:main' into main
bleudev May 6, 2024
19cf226
Merge branch 'main' into main
bleudev May 11, 2024
7ee99b2
Change `0.22.0` to `0.22.1` in deprecations
bleudev May 11, 2024
aa77fb5
Fix `except ImportError`
bleudev May 19, 2024
8278fd8
Remove `add/insert/remove` methods + remove magic methods
bleudev May 23, 2024
d629ea0
Merge branch 'main' into main
bleudev May 24, 2024
842f84c
Fix `SyntaxError` and fix `Optional`
bleudev May 24, 2024
e84d725
Fix `TypeError`
bleudev May 24, 2024
3b4f26e
Remove `Args` and `Kwargs` from `types.py`
bleudev May 24, 2024
a18a4fa
Merge branch 'main' into main
bleudev May 24, 2024
10a3f3e
Delete auto_update
bleudev May 29, 2024
cc6e567
Merge branch 'flet-dev:main' into main
bleudev May 29, 2024
4900907
Merge branch 'main' into main
bleudev May 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions sdk/python/packages/flet-core/src/flet_core/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
from flet_core.circle_avatar import CircleAvatar
from flet_core.column import Column
from flet_core.container import Container, ContainerTapEvent
from flet_core.control import Control, OptionalNumber
from flet_core.control import Control
from flet_core.control_event import ControlEvent
from flet_core.cupertino_action_sheet import CupertinoActionSheet
from flet_core.cupertino_action_sheet_action import CupertinoActionSheetAction
Expand Down Expand Up @@ -171,7 +171,7 @@
from flet_core.icon import Icon
from flet_core.icon_button import IconButton
from flet_core.image import Image
from flet_core.list_tile import ListTile, ListTileTitleAlignment, ListTileStyle
from flet_core.list_tile import ListTile, ListTileStyle, ListTileTitleAlignment
from flet_core.list_view import ListView
from flet_core.lottie import Lottie
from flet_core.margin import Margin
Expand All @@ -180,8 +180,8 @@
from flet_core.menu_item_button import MenuItemButton
from flet_core.navigation_bar import (
NavigationBar,
NavigationBarDestination,
NavigationBarLabelBehavior,
NavigationDestination,
)
from flet_core.navigation_drawer import NavigationDrawer, NavigationDrawerDestination
from flet_core.navigation_rail import (
Expand Down Expand Up @@ -317,20 +317,26 @@
BoxShape,
Brightness,
ClipBehavior,
ColorStr,
ControlEventFunction,
CrossAxisAlignment,
FloatingActionButtonLocation,
FontWeight,
IconStr,
ImageFit,
ImageRepeat,
LabelPosition,
MainAxisAlignment,
MaterialState,
MouseCursor,
NotchShape,
Number,
OptionalNumber,
Orientation,
PaddingValue,
PagePlatform,
ScrollMode,
SupportsStr,
TabAlignment,
TextAlign,
ThemeMode,
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/packages/flet-core/src/flet_core/app_bar.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

from flet_core.adaptive_control import AdaptiveControl
from flet_core.buttons import OutlinedBorder
from flet_core.control import Control, OptionalNumber
from flet_core.control import Control
from flet_core.ref import Ref
from flet_core.text_style import TextStyle
from flet_core.types import ClipBehavior
from flet_core.types import ClipBehavior, OptionalNumber


class AppBar(AdaptiveControl):
Expand Down
4 changes: 3 additions & 1 deletion sdk/python/packages/flet-core/src/flet_core/column.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@

from flet_core.adaptive_control import AdaptiveControl
from flet_core.constrained_control import ConstrainedControl
from flet_core.control import Control, OptionalNumber
from flet_core.control import Control
from flet_core.ref import Ref
from flet_core.scrollable_control import ScrollableControl
from flet_core.types import (
AnimationValue,
CrossAxisAlignment,
MainAxisAlignment,
OffsetValue,
OptionalNumber,
ResponsiveNumber,
RotateValue,
ScaleValue,
Expand Down Expand Up @@ -157,6 +158,7 @@ def _get_control_name(self):
def _get_children(self):
return self.__controls

# Public methods
def clean(self):
super().clean()
self.__controls.clear()
Expand Down
Loading