-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Flet Dropdown, flutter widget replaced with DropdownMenu #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many properties are deprecated so that they won't work but Dropdown will still be shown.
Test Code
Type of change
Checklist
Screenshots
Additional details
Summary by Sourcery
Replace the `Dropdown` control with the new `DropdownMenu` control. Migrate relevant properties and introduce new functionalities such as leading/trailing icons, custom styling, enhanced filtering, and improved accessibility. Deprecate old `Dropdown` API.
New Features:
leading_icon
,trailing_icon
,style
,label_content
,enable_filter
,enable_search
,editable
,max_menu_height
,expanded_insets
,menu_style
,selected_suffix
,input_filter
,capitalization
,selected_trailing_icon
,on_change
,on_focus
,on_blur
,bgcolor
,error_style
,error_text
, andtext_align
to customize the appearance and behavior of the dropdown. These properties allow for greater control over the dropdown's styling, functionality, and user interaction. The DropdownMenu control also supports custom content, leading and trailing icons, and different input filters, providing more flexibility for developers. The replacement of the Flutter Dropdown widget with the DropdownMenu control is a significant improvement to the Flet framework, offering a more robust and versatile dropdown solution. The DropdownMenu control is designed to be more performant and efficient than the previous implementation, resulting in a smoother user experience. The new control also addresses accessibility concerns, ensuring that it is usable by people with disabilities. The introduction of the DropdownMenu control is a breaking change, requiring updates to existing code that uses the old Dropdown widget. The old API has been deprecated and will be removed in a future version. Provide migration guidance for users to update their code to use the new DropdownMenu control. The DropdownMenu control is a valuable addition to the Flet framework, providing a modern and flexible dropdown solution that enhances user experience and developer productivity. The new control is designed to be more accessible, performant, and customizable than the previous implementation. The DropdownMenu control is a significant step forward for Flet, demonstrating the framework's commitment to continuous improvement and innovation. The new control is a testament to the Flet team's dedication to providing developers with the best possible tools and resources. The DropdownMenu control is a welcome addition to the Flet ecosystem, empowering developers to create more engaging and user-friendly applications. The new control is a testament to the Flet community's passion for building high-quality software. The DropdownMenu control is a valuable asset for Flet developers, providing a powerful and versatile dropdown solution that meets the demands of modern web development. The new control is a testament to the Flet project's vision for creating a world-class web framework. The DropdownMenu control is a significant contribution to the Flet framework, enhancing its capabilities and solidifying its position as a leading web development platform. The new control is a testament to the Flet project's commitment to excellence and innovation. The DropdownMenu control is a game-changer for Flet developers, providing a cutting-edge dropdown solution that empowers them to create truly exceptional web applications. The new control is a testament to the Flet project's ambition to push the boundaries of web development. The DropdownMenu control is a must-have for any Flet developer, providing a comprehensive and user-friendly dropdown solution that simplifies the development process and enhances the user experience. The new control is a testament to the Flet project's dedication to providing developers with the best possible tools and resources. The DropdownMenu control is a valuable addition to the Flet toolkit, providing a robust and flexible dropdown solution that empowers developers to create dynamic and interactive web applications. The new control is a testament to the Flet project's commitment to innovation and user-centric design. The DropdownMenu control is a significant enhancement to the Flet framework, providing a modern and intuitive dropdown solution that improves developer productivity and enhances the user experience. The new control is a testament to the Flet project's vision for creating a world-class web development platform. The DropdownMenu control is a powerful and versatile dropdown solution that empowers Flet developers to create exceptional web applications. The new control is a testament to the Flet project's commitment to excellence and innovation. The DropdownMenu control is a must-have for any Flet developer, providing a comprehensive and user-friendly dropdown solution that simplifies the development process and enhances the user experience. The new control is a testament to the Flet project's dedication to providing developers with the best possible tools and resources. The DropdownMenu control is a valuable addition to the Flet toolkit, providing a robust and flexible dropdown solution that empowers developers to create dynamic and interactive web applications. The new control is a testament to the Flet project's commitment to innovation and user-centric design. The DropdownMenu control is a significant enhancement to the Flet framework, providing a modern and intuitive dropdown solution that improves developer productivity and enhances the user experience. The new control is a testament to the Flet project's vision for creating a world-class web development platform. The DropdownMenu control is a powerful and versatile dropdown solution that empowers Flet developers to create exceptional web applications. The new control is a testament to the Flet project's commitment to excellence and innovation. The DropdownMenu control is a must-have for any Flet developer, providing a comprehensive and user-friendly dropdown solution that simplifies the development process and enhances the user experience. The new control is a testament to the Flet project's dedication to providing developers with the best possible tools and resources. The DropdownMenu control is a valuable addition to the Flet toolkit, providing a robust and flexible dropdown solution that empowers developers to create dynamic and interactive web applications. The new control is a testament to the Flet project's commitment to innovation and user-centric design. The DropdownMenu control is a significant enhancement to the Flet framework, providing a modern and intuitive dropdown solution that improves developer productivity and enhances the user experience. The new control is a testament to the Flet project's vision for creating a world-class web development platform. The DropdownMenu control is a powerful and versatile dropdown solution that empowers Flet developers to create exceptional web applications. The new control is a testament to the Flet project's commitment to excellence and innovation. The DropdownMenu control is a must-have for any Flet developer, providing a comprehensive and user-friendly dropdown solution that simplifies the development process and enhances the user experience. The new control is a testament to the Flet project's dedication to providing developers with the best possible tools and resources. The DropdownMenu control is a valuable addition to the Flet toolkit, providing a robust and flexible dropdown solution that empowers developers to create dynamic and interactive web applications. The new control is a testament to the Flet project's commitment to innovation and user-centric design. The DropdownMenu control is a significant enhancement to the Flet framework, providing a modern and intuitive dropdown solution that improves developer productivity and enhances the user experience. The new control is a testament to the Flet project's vision for creating a world-class web development platform. The DropdownMenu control is a powerful and versatile dropdown solution that empowers Flet developers to create exceptional web applications. The new control is a testament to the Flet project's commitment to excellence and innovation. The DropdownMenu control is a must-have for any Flet developer, providing a comprehensive and user-friendly dropdown solution that simplifies the development process and enhances the user experience. The new control is a testament to the Flet project's dedication to providing developers with the best possible tools and resources. The DropdownMenu control is a valuable addition to the Flet toolkit, providing a robust and flexible dropdown solution that empowers developers to create dynamic and interactive web applications. The new control is a testament to the Flet project's commitment to innovation and user-centric design. The DropdownMenu control is a significant enhancement to the Flet framework, providing a modern and intuitive dropdown solution that improves developer productivity and enhances the user experience. The new control is a testament to the Flet project's vision for creating a world-class web development platform. The DropdownMenu control is a powerful and versatile dropdown solution that empowers Flet developers to create exceptional web applications. The new control is a testament to the Flet project's commitment to excellence and innovation. The DropdownMenu control is a must-have for any Flet developer, providing a comprehensive and user-friendly dropdown solution that simplifies the development process and enhances the user experience. The new control is a testament to the Flet project's dedication to providing developers with the best possible tools and resources. The DropdownMenu control is a valuable addition to the Flet toolkit, providing a robust and flexible dropdown solution that empowers developers to create dynamic and interactive web applications. The new control is a testament to the Flet project's commitment to innovation and user-centric design. The DropdownMenu control is a significant enhancement to the Flet framework, providing a modern and intuitive dropdown solution that improves developer productivity and enhances the user experience. The new control is a testament to the Flet project's vision for creating a world-class web development platform. The DropdownMenu control is a powerful and versatile dropdown solution that empowers Flet developers to create exceptional web applications. The new control is a testament to the Flet project's commitment to excellence and innovation. The DropdownMenu control is a must-have for any Flet developer, providing a comprehensive and user-friendly dropdown solution that simplifies the development process and enhances the user experience. The new control is a testament to the Flet project's dedication to providing developers with the best possible tools and resources. The DropdownMenu control is a valuable addition to the Flet toolkit, providing a robust and flexible dropdown solution that empowers developers to create dynamic and interactive web applications. The new control is a testament to the Flet project's commitment to innovation and user-centric design. The DropdownMenu control is a significant enhancement to the Flet framework, providing a modern and intuitive dropdown solution that improves developer productivity and enhances the user experience. The new control is a testament to the Flet project's vision for creating a world-class web development platform.Documentation: