refactor(utils): qa

Signed-off-by: Lexus Drumgold <[email protected]>

src/utils/add-ext.ts

@@ -30,8 +30,9 @@ import formatExt from './format-ext'
 const addExt = (path: string, ext?: Nullable<string>): string => {
   validateString(path, 'path')
 
-  // exit early if extension isn't provided or validate ext
+  // exit early if extension isn't provided
   if (ext === null || ext === undefined) return path
+  // validate file extension
   else validateString(ext, 'ext')
 
   // exit early if extension is empty string or path already ends with extension

src/utils/change-ext.ts

@@ -33,19 +33,23 @@ import formatExt from './format-ext'
 const changeExt = (path: string, ext?: Nullable<string>): string => {
   validateString(path, 'path')
 
-  // exit early if extension isn't provided or validate ext
+  // exit early if extension isn't provided
   if (ext === null || ext === undefined) return path
+  // validate file extension
   else validateString(ext, 'ext')
 
   // exit early if extension is empty string
   if (!ext.trim()) return path
 
+  // ensure path does not end with dot character
+  path = path.replace(/\.$/, '')
+
   /**
    * File extension of {@linkcode path}.
    *
    * @const {EmptyString | Ext} extension
    */
-  const extension: EmptyString | Ext = extname((path = path.replace(/\.$/, '')))
+  const extension: EmptyString | Ext = extname(path)
 
   return extension
     ? path.replace(new RegExp(`\\${extension}$`), formatExt(ext))

src/utils/default-ext.ts

@@ -41,8 +41,9 @@ const defaultExt = (
 ): string => {
   validateString(path, 'path')
 
-  // exit early if extension isn't provided or validate ext
+  // exit early if extension isn't provided
   if (ext === null || ext === undefined) return path
+  // validate file extension
   else validateString(ext, 'ext')
 
   // exit early if extension is empty string
@@ -62,12 +63,15 @@ const defaultExt = (
         .filter(ignorable => ignorable.trim().length > 0)
     : []
 
+  // ensure path does not end with dot character
+  path = path.replace(/\.$/, '')
+
   /**
    * File extension of {@linkcode path}.
    *
    * @const {EmptyString | Ext} extension
    */
-  const extension: EmptyString | Ext = extname((path = path.replace(/\.$/, '')))
+  const extension: EmptyString | Ext = extname(path)
 
   return extension && !ignore.includes(extension) ? path : addExt(path, ext)
 }

src/utils/remove-ext.ts

@@ -30,8 +30,9 @@ import formatExt from './format-ext'
 const removeExt = (path: string, ext?: Nullable<string>): string => {
   validateString(path, 'path')
 
-  // exit early if extension isn't provided or validate ext
+  // exit early if extension isn't provided
   if (ext === null || ext === undefined) return path
+  // validate file extension
   else validateString(ext, 'ext')
 
   // exit early if extension is empty string