-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loading/download part of the data #545
Comments
Actually this is not exactly how this works, it is not exactly equivalent to the In the reorg, only the json string of the model at the top level is stored. So in the
In this case, you can selectively load a single one of those from the We should think about whether and how to handle this from a |
Note that your test works because you're loading a FluxDataArray which has a simple |
So I just added a test that I think illustrates what you're saying in which we try to load a Is this illustrative of the problem you are explaining above? I fixed the test by adding something to To illustrate the steps: pulse = GaussianPulse.from_file('source.hdf5', group_path='/source_time')
# first, grab the `json_dict` for the source at the top level
# then access `json_dict[source_time]`
# also, access the hdf5 group `f_handle[source_time]`
# proceed as normal See the changes in this commit Hopefully this resolves at least part of the concern? |
I think this works now yeah. The second (optional) request is to be able to only download part of the data. I think this may eventually be coupled with the denormalizer. |
Yea, for download, we probably need changes to the web api for example? |
@dbochkov-flexcompute any thoughts on this as part of the denormalizer efforts? |
I guess I see these options so far:
|
@xin-flex any thoughts? |
For 1. the method to divide data needs to be predefined and lacks flexibility, and takes more storage |
if we can do some processing on server side, then a simpler approach is probably to just open and save separately data for requested monitor from the non-denormalizer simulation data, something like:
|
agree |
what's the status of this issue? are we still going to work on this? or saving for later? |
I think this is still worthwhile to have, maybe not very urgent though |
This is partially solved by #1249 . still not possible to download part of the hdf5 file, but I dont know if we want to allow that. should we close? |
Is your feature request related to a problem? Please describe.
The hdf5 data size is sometimes too large to fit into memory.
Describe the solution you'd like
The text was updated successfully, but these errors were encountered: