Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a new branch to start the data refactor from scratch.
To Do List:
near2far.py
tocomponents/
, mergemonitor_data.py
and `monitor_data_n2f.pytd
namespace imports totidy3d/__init__.py
, moveSymmetry
totypes.py
..json
, write components as string inhdf5
.MonitorData
methods (eg.apply_symmery()
with properties using stored).DataArray
subclassing fromxr.DataArray
Dataset
abstraction layer, test if circular imports are avoided.monitor_data
a property and add tuple ofMonitorData
, fix the getitem and other operations.Backend Changes Needed
DataArray
on the backend, usenp.zeros()
with the correct shape (including a 0).symmetry
,symmetry_center
, andgrid_expanded
toFieldData
-like objects when they are created. If left out, it will just assumesymmetry=(0,0,0)
..load_from_handle()
classmethod
, it’s used a couple times in the backend, we need to find a different approach.coords
must be aligned with theshape
of theDataArray.data
. Sometimes this might not be the case, I had to fix a few times in the front end.