Reorganize geometry.py #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twhughes
force-pushed
the
tyler/geo_reorg
branch
2 times, most recently
from
f54d590 to
cd081df
Compare
Closed
twhughes
force-pushed
the
tyler/geo_reorg
branch
2 times, most recently
from
406eaac to
1054e2e
Compare
momchil-flex
approved these changes
Jun 17, 2022
twhughes
force-pushed
the
tyler/geo_reorg
branch
from
1054e2e to
52b12f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of reorganization so we dont abuse pydantic validators.
Geometry.centerand added it as another abstract class thatBox,Sphere, andCylinderinherit from.Planar.lengthand added it explicitly toCylinder.center_axisandlength_axisproperties toPlanar, which must be implemented in subclasses for the planar logic to function appropriately.Result is that validators are no longer used to set fields.
Note that version was changed to 1.5.0 because it introduces a minor schema change (no longer a "center" and "length" in PolySlab schema).