Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to capture issue 398. #434

Merged
merged 1 commit into from
Feb 1, 2020
Merged

Add a test to capture issue 398. #434

merged 1 commit into from
Feb 1, 2020

Conversation

hongkai-dai
Copy link
Contributor

@hongkai-dai hongkai-dai commented Jan 24, 2020 •
edited by sherm1
Loading

Resolves #398

This change is Reviewable

hongkai-dai
hongkai-dai commented Jan 24, 2020
View reviewed changes
Copy link
Contributor Author

@hongkai-dai hongkai-dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@SeanCurtis-TRI for feature review please, thanks!

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @SeanCurtis-TRI)

SeanCurtis-TRI
SeanCurtis-TRI reviewed Jan 31, 2020
View reviewed changes
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a quick rebase, please?

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @SeanCurtis-TRI)

hongkai-dai
hongkai-dai commented Jan 31, 2020
View reviewed changes
Copy link
Contributor Author

@hongkai-dai hongkai-dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rebased.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @SeanCurtis-TRI)

SeanCurtis-TRI
SeanCurtis-TRI approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

+@sherm1 for platform review.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sherm1)

sherm1
sherm1 approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform :lgtm: -- thanks, Hongkai!

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sherm1)

@sherm1 sherm1 merged commit c264b45 into flexible-collision-library:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanCurtis-TRI SeanCurtis-TRI SeanCurtis-TRI approved these changes

@sherm1 sherm1 sherm1 approved these changes

Assignees

@sherm1 sherm1

@SeanCurtis-TRI SeanCurtis-TRI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Another FCL bug that calls EPA while the origin is outside the polytope
3 participants
@hongkai-dai @sherm1 @SeanCurtis-TRI