Merge pull request #1680 from flexn-io/chore/cherry-pick-offline-mode…

…-option add offline mode option
flexn-io · Sep 4, 2024 · 0858f77 · 0858f77
2 parents 9da8f0d + c54f160
commit 0858f77
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 2 deletions.
diff --git a/packages/core/src/tasks/taskOptions.ts b/packages/core/src/tasks/taskOptions.ts
@@ -99,6 +99,10 @@ export const RnvTaskOptions = createTaskOptionsMap([
         altKey: 'skipDependencyCheck',
         description: 'Skips auto update of npm dependencies if mismatch found',
     },
+    {
+        key: 'offline',
+        description: 'Run without connecting to the internet whenever possible',
+    },
     {
         key: 'app-config-ID',
         altKey: 'appConfigID',
@@ -232,6 +236,7 @@ export const RnvTaskCoreOptionPresets = createTaskOptionsPreset({
         RnvTaskOptions.json,
         RnvTaskOptions.noSummary,
         RnvTaskOptions.noIntro,
+        RnvTaskOptions.offline,
         RnvTaskOptions.skipDependencyCheck,
     ],
 });

diff --git a/packages/engine-core/src/taskHelpers.ts b/packages/engine-core/src/taskHelpers.ts
@@ -4,9 +4,10 @@ import {
     getContext,
     installPackageDependencies,
     logDefault,
+    logInfo,
     overrideTemplatePlugins,
 } from '@rnv/core';
-import { configureFonts } from '@rnv/sdk-utils';
+import { configureFonts, isOfflineMode } from '@rnv/sdk-utils';
 
 export const installPackageDependenciesAndPlugins = async () => {
     logDefault('installPackageDependenciesAndPlugins');
@@ -21,7 +22,13 @@ export const installPackageDependenciesAndPlugins = async () => {
 
 export const checkAndInstallIfRequired = async () => {
     const ctx = getContext();
-    if (ctx.program.opts().skipDependencyCheck) return true;
+    if (isOfflineMode('install package dependencies and plugins')) {
+        return true;
+    }
+    if (ctx.program.opts().skipDependencyCheck) {
+        logInfo(`Skipping installing package dependencies and plugins due to --skip-dependency-check option`);
+        return true;
+    }
     const isNmInstalled = areNodeModulesInstalled();
     if (isNmInstalled && !ctx._requiresNpmInstall) {
         return true;

diff --git a/packages/sdk-react-native/src/iosRunner.ts b/packages/sdk-react-native/src/iosRunner.ts
@@ -20,6 +20,7 @@ import { EnvVars } from './env';
 import shellQuote from 'shell-quote';
 import path from 'path';
 import crypto from 'crypto';
+import { isOfflineMode } from '@rnv/sdk-utils';
 
 export const packageReactNativeIOS = (isDev = false) => {
     const c = getContext();
@@ -126,6 +127,9 @@ const checkIfPodsIsRequired = (
     c: RnvContext,
     forceUpdatePods: boolean
 ): { result: boolean; reason: string; code: number } => {
+    if (isOfflineMode()) {
+        return { result: false, reason: 'You passed --offline option', code: 7 };
+    }
     if (c.runtime._skipNativeDepResolutions) {
         return { result: false, reason: `Command ${getCurrentCommand(true)} explicitly skips pod checks`, code: 1 };
     }

diff --git a/packages/sdk-utils/src/getCliOptions.ts b/packages/sdk-utils/src/getCliOptions.ts
@@ -0,0 +1,12 @@
+import { getContext, logInfo } from '@rnv/core';
+
+export const isOfflineMode = (logMessage?: string) => {
+    if (getContext().program.opts().offline) {
+        if (logMessage) {
+            logInfo(`Skipping "${logMessage}" due to --offline option`);
+        }
+        return true;
+    } else {
+        return false;
+    }
+};
diff --git a/packages/sdk-utils/src/index.ts b/packages/sdk-utils/src/index.ts
@@ -5,3 +5,4 @@ export * from './ipUtils';
 export * from './utils';
 export * from './target';
 export * from './axiosUtils';
+export * from './getCliOptions';