Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore post refactor fixes pt3 #1129

Merged
merged 8 commits into from
Oct 8, 2023
Merged

Chore post refactor fixes pt3 #1129

merged 8 commits into from
Oct 8, 2023

Conversation

pavjacko
Copy link
Member

@pavjacko pavjacko commented Oct 5, 2023

Description

  • additional fixes

Breaking Changes

  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

mihaiblaga89 and others added 2 commits October 5, 2023 16:51
* main:
  run ios/tvos in parallel
  use metro config defaults
  cleanup engine adapters
  fix: incorrect logger imports in sdk-webpack
@pavjacko pavjacko marked this pull request as draft October 5, 2023 14:40
pavjacko and others added 6 commits October 5, 2023 17:59
…enative into chore/post-refactor-fixes-pt3

* 'chore/post-refactor-fixes-pt3' of github.com:flexn-io/renative:
  fix: lock gemfile to working activesupport version
@pavjacko pavjacko self-assigned this Oct 8, 2023
@pavjacko pavjacko marked this pull request as ready for review October 8, 2023 13:07
@pavjacko pavjacko merged commit be53961 into main Oct 8, 2023
@pavjacko pavjacko deleted the chore/post-refactor-fixes-pt3 branch October 8, 2023 13:57
@pavjacko pavjacko added this to the 1.0 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants