-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic templates & Typed Schema #1177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed type of this node exceeds the maximum length the compiler will serialize
if (runScheme) { | ||
if (!ps.includes('-configuration')) { | ||
p.push('-configuration'); | ||
p.push(runScheme); |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
This shell argument which depends on [library input](1) is later used in a [shell command](2).
This shell argument which depends on [library input](3) is later used in a [shell command](2).
if (runScheme) { | ||
if (!ps.includes('-configuration')) { | ||
p.push('-configuration'); | ||
p.push(runScheme); |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
This shell argument which depends on [library input](1) is later used in a [shell command](2).
mihaiblaga89
approved these changes
Oct 16, 2023
… this node exceeds the maximum length.." , add integration schema, refactor names
* main: 1.0.0-canary.7 fix missing android template files, added correct licenses fixed linting missing metro-config dep clean fix test 1.0.0-canary.6 attempt to fix plugins 1.0.0-canary.5 add metro-config to template fix/export_log fix/macos_build_location_info fix fix/androidwear fix/androidwear fix/web_export fixed test leftover test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
I have tested my changes on:
ReNative project directly:
New project:
Existing Project created with previous version of renative: